introduce a new locking scheme in ExecutionLockService, and apply it in a number of places where race conditions can occur #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerstraeteBert
approved these changes
Apr 29, 2025
6 tasks
vincent-cognite
commented
Apr 30, 2025
| * | ||
| * @param lockId | ||
| */ | ||
| public void waitForLock(String lockId) { |
|
Any updates on this @manan164 ? |
|
@kgoeltner @bradyyie @manan164 Please review |
v1r3n
approved these changes
Jun 7, 2025
6 tasks
lbestatlas
reviewed
Jun 26, 2025
| @@ -112,6 +116,12 @@ public void execute(WorkflowSystemTask systemTask, String taskId) { | |||
| boolean hasTaskExecutionCompleted = false; | |||
| boolean shouldRemoveTaskFromQueue = false; | |||
| String workflowId = task.getWorkflowInstanceId(); | |||
There was a problem hiding this comment.
It doesn't look like this lock gets released.
lbestatlas
reviewed
Jun 26, 2025
| } | ||
|
|
||
| var releaseDistributedLock = false; | ||
|
|
There was a problem hiding this comment.
AFAIK the Redis Implementation was already reentrant, if there is an implementation that is not, shouldn't that implementation be change instead?
There was a problem hiding this comment.
I don't think that should be the case. The solution provided here is rather simple, while offering a robust re-entrance. Having to duplicate this logic in some way shape or form for all locking DAOs does not feel productive, and can lead to more issues down the line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
We see that sometimes workflows can end up in a state where some tasks are IN_PROGRESS while the workflow is TERMINATED, FAILED, TIMED_OUT, ...
This is due to lack of locking on some critical parts where you can have concurrent access to update a workflow.
In order to fix that we suggest to improve the ExecutionLockService and introduce a LockInstance that is autoclosable.
The new lock mechanism also supports reentrance, and still relies on the underlying storage locking support (Postgres, Redis, ...)
It has proved to be robust in our testing, and this is what we use now in production.
Something to be aware is that there can be more contention on workflows with large number of tasks that are updated simultaneously.