Feature sede tests #494
Merged
Feature sede tests #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creating extra entities for self references
Adding value for generics
…hatCompletion.java
…hatCompletion.java in src/test directory
…hatCompletion.java in src/test directory
v1r3n
approved these changes
May 5, 2025
v1r3n
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
Added serialisation deserialisation tests for all POJOs in java sdk
Structure :
I have created a json file for all the json objects which are created using server POJOs (workflow+ LLM) : ser_deser_json_string.json
this JSON uses dynamic replacement for POJO fields
Objects resolution happens using a utility class : JsonTemplateSerDeserResolverUtil.java
JsonTemplateSerDeserResolverUtil.java and ser_deser_json_string.json are duplicated in both the modules : conductor-client and orkes-client
The tests have following standard structure :
In couple of POJOs there were missing fields - which I found because of these tests so I have added those fields.