Introduce Signal API and SYNC-DURABLE consisteny during execution #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4dd6550 to
af08882
Compare
v1r3n
reviewed
Apr 17, 2025
| * @param consistency Execution consistency mode (DURABLE or SYNC) | ||
| * @return A CompletableFuture containing the TaskRun with blocking task details including input data | ||
| */ | ||
| public CompletableFuture<TaskRun> executeWorkflowWithBlockingTaskInput(StartWorkflowRequest req, |
There was a problem hiding this comment.
This should be INPUT which is a Map<String, Object>
There was a problem hiding this comment.
We usually accept StartWorkflowRequest which contains all the information from Request body right ?
e6092a2 to
80b8b6f
Compare
- Add SignalResponse model with helper methods - Add ReturnStrategy enum support - Update TaskClient and WorkflowClient APIs - Add comprehensive test coverage - Maintain backward compatibility
5d2ebd1 to
b5a3a3d
Compare
|
|
||
| import lombok.Data; | ||
|
|
||
| @Data |
There was a problem hiding this comment.
annotations like other pojos. please check
There was a problem hiding this comment.
updated code with similar annotation on other pojos
7efded5 to
29ff312
Compare
29ff312 to
7c72af5
Compare
c7bac00 to
74f41a4
Compare
v1r3n
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Describe the new behavior from this PR, and why it's needed
Issue #
Alternatives considered
Describe alternative implementation you have considered