Update SDK POJOs to have Lombok annotations #463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR contains too many breaking and potentially breaking changes. Shouldn't be merged. |
jmigueprieto
reviewed
Apr 9, 2025
...-sdk/conductor-client/src/main/java/com/netflix/conductor/common/metadata/tasks/TaskDef.java
Show resolved
Hide resolved
jmigueprieto
reviewed
Apr 9, 2025
|
|
||
| private final String message = "Bulk Request has been processed."; | ||
| private String message = "Bulk Request has been processed."; |
There was a problem hiding this comment.
This is making private final String message which was meant to remain private and immutable accessible trough a getter (unnecessarily) and mutable.
There was a problem hiding this comment.
Why do we want this field to be immutable ?
Why do we want to have special treatment ?
There was a problem hiding this comment.
@orkes-harshil take a look at the code. Check how message is being used.
...java-sdk/conductor-client/src/main/java/com/netflix/conductor/common/metadata/Auditable.java
Outdated
Show resolved
Hide resolved
d8e7489 to
7c317bc
Compare
…ssue - adding arguments constructors where ever it was there to avoid backward compatibility issues
v1r3n
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description :
This PR moves all java sdk POJOs to lombok annotations.
We will have
@DaTa
@builder
@NoArgsConstructor
@AllArgsConstructor
Our goal is to not break current backward compatibility. We have added unit tests in a previous PR for all the accessors and constructors which are deleted as part of Lombokisation.
This will be a base on which we will sync sdk POJOs with server POJOs.