[Feature] Adding support for Kafka in the Workflow Event Listener #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added new WorkflowEventType with Additional events for the WorkflowStatusListener. - Added WorkflowSummaryExtended that extends WorkflowSummary, it maintains input and output properties as objects when publishing objects to Kafka. - Moved rasing of Workflow Finalized event from cancelNonTerminalTasks to endExecution to make sure it is only rasied once.
|
Sent back to draft as i found that the does not work for the case where the workflow is terminated through the API/UI does not raise the Finalize event. So back to square one with duplicated finalized events. |
…en it was not raised at all.
|
finalized is now raised the correct amount of times. |
|
Thanks @Robban1980 ! I've assigned it to an engineer and labeled. |
bradyyie
approved these changes
Apr 8, 2025
v1r3n
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
This PR adds the new Workflow Event Publisher
kafka. It gives support to publish workflow events to Kafka. In addition to the existing events, Completed, Terminated and Finalized the following new events have been added:That addition of these new events does not change the behavior of the existing publishers, they are unchanged.
A new type
WorkflowSummaryExtendedwas added that extends the WorkflowSummary, it maintains input and output properties as objects when publishing objects to Kafka.Moved rising of WorkflowFINALIZEDevent fromcancelNonTerminalTaskstoendExecutionin theWorkflowExecutionOps.javato make sure it is only raised once. Currently when using a Terminate Task in a workflow it is razed twice.To ensure that
FINALIZEDis raised to correct number of times, an overloadedcancelNonTerminalTaskswas introduced to control if this event should be raised or not, by default it is raised. This is because thecancelNonTerminalTasksis called twice whenendExecutionis part of the flow. WhencancelNonTerminalTasksis called fromendExecutionit should not raise the event again.Issue #