Added support to bind workflow instance id to parameter for worker task in SDK #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jmigueprieto In the presented implementation the workflow instance id is bound to a String parameter. Perhaps it's better and nicer to bind it to a UUID parameter. Even both could be supported: if the parameter is type String, just bind it. If the parameter type is UUID, parse it and bind it. Let me know what you think! @l0lcat String is correct because the id scheme is UUID today but could be different as well. ID generator is pluggable component which means someone change it to generate ids which are unique but does not conform to UUID spec. |
ed6a90a to
b0645be
Compare
|
@v1r3n, I removed the support of UUID parameter for assigning the workflowId based on feedback (we can't be sure it wil always be a UUID). |
v1r3n
approved these changes
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Added annotation WorkflowInstanceIdInputParam to the SDK. This can be used on a String parameter of a WorkerTask method. The parameter will be assigned the value of the workflowInstanceId if it is annotated with the WorkflowInstanceIdInputParam.
The workflowInstanceId is useful for persisting with entities in a data store and for logging purposes. The alternative is to have a Task type parameter and get it from there, but it cannot be combined with the InputParam annotation. It's also more elegant to use an annotation.
Alternatives considered
Describe alternative implementation you have considered