Skip to content

Unify environment variable usage #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 6, 2025
Merged

Unify environment variable usage #353

merged 2 commits into from
Jan 6, 2025

Conversation

jmigueprieto
Copy link
Contributor

@jmigueprieto jmigueprieto commented Jan 4, 2025 •
edited
Loading

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • WHOSUSING.md
  • Other (please describe):

Changes in this PR

Added support for:

  • CONDUCTOR_SERVER_URL
  • CONDUCTOR_AUTH_KEY
  • CONDUCTOR_AUTH_SECRET

Same env variables used in Python and Go SDK. Env variables are used when:

(1) Creating a new instance of ApiClient (Orkes Client) with its no-args constructor. E.g.:

var client = new ApiClient();

(2) Creating a new instance of ConductorClient or ApiClient with useEnvVariables(true). E.g.:

var client = ConductorClient.builder()
            .useEnvVariables(true)
            .build()

@jmigueprieto jmigueprieto self-assigned this Jan 4, 2025
@jmigueprieto jmigueprieto force-pushed the feature/java-orkes-client-uses-env-vars branch from 0f5807a to e89d2a2 Compare January 6, 2025 18:50
@jmigueprieto
- Changes in integration test env variables to use the standard vars.
aabce37 
- Make ApiClient env variable support backwards compatible
@jmigueprieto jmigueprieto changed the title (WIP) Unify environment variable usage Unify environment variable usage Jan 6, 2025
@jmigueprieto jmigueprieto marked this pull request as ready for review January 6, 2025 20:05
@jmigueprieto jmigueprieto merged commit 12b483c into main Jan 6, 2025
10 checks passed
@jmigueprieto jmigueprieto deleted the feature/java-orkes-client-uses-env-vars branch January 6, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v1r3n v1r3n v1r3n approved these changes

@c4lm c4lm Awaiting requested review from c4lm

@ystxn ystxn Awaiting requested review from ystxn

@codehackerr codehackerr Awaiting requested review from codehackerr

@Haven-King Haven-King Awaiting requested review from Haven-King

@manan164 manan164 Awaiting requested review from manan164

Assignees

@jmigueprieto jmigueprieto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmigueprieto @v1r3n