Skip to content

Conversation

mariash
Copy link
Contributor

@mariash mariash commented Jul 24, 2024

Google Artifacts Registry mirror requires application/vnd.oci.image.index.v1+json media type in Accept headers. Otherwise, you will get an error in docker-image-resource that client doesn't accept that media-type and the check command won't be able to fetch the manifest digest.

We were having an issue running the test since the supported ginkgo is outdated, please verify and fix as needed.

Signed-off-by: Andy Nguyen <andy-a.nguyen@broadcom.com>
Co-authored-by: Andy Nguyen <andy-a.nguyen@broadcom.com>
@mariash mariash requested a review from xtremerui as a code owner July 24, 2024 18:42
@mariash mariash changed the title Support GCR mirror that send application/vnd.oci.image.index.v1+json Support GAR mirror that send application/vnd.oci.image.index.v1+json Jul 24, 2024
Copy link
Contributor

@xtremerui xtremerui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xtremerui xtremerui merged commit 45436ac into concourse:master Sep 3, 2024
1 of 2 checks passed
@xtremerui
Copy link
Contributor

merging as the test already passed in previous run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants