web: handle timezones #3664
Merged
web: handle timezones #3664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#2226 Signed-off-by: Jamie Klassen <cklassen@pivotal.io>
Signed-off-by: Jamie Klassen <cklassen@pivotal.io>
vito
approved these changes
Apr 2, 2019
|
|
||
| &::before { |
There was a problem hiding this comment.
🤔 I can't remember why this was done this way before, but it seems to be fine either way. Looks like this makes it possible to test, so 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2226
I've chosen to approach this PR as essentially a bugfix, as I took a shortcut and always showed UTC when upgrading to elm 0.19.
The task that requests the current time zone from the browser can fail. In this case we default to showing UTC. I think it may be worthwhile in general to surface the timezone in various places where we show timestamps, or at least to give some explanation of the default choice of UTC in the failure case. However I'd like to keep that out of the scope of this PR.