Fix upgrade/downgrade #3190
Merged
Fix upgrade/downgrade #3190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prior to this change the 'fly workers' could list the *old* worker and fool the script into continuing on it'd be nice if ephemeral workers disappeared immediately on normal shutdown 🤷 Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
this allows the smoke-tests to always run against the latest version, so we don't need to version it, and should provide enough assurance that things are still working. also fixes #2149 Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2149, improves the polling for worker to be available (important for worker version bumps), and also uh, makes them work again post-refactor (which was merged quicker to expedite
concourse/devfix)this can be verified with: