Support for cc.xml #2759

cburgmer · 2018-11-05T20:16:09Z

This PR tries to implement what's being asked for in #438.

Following the documentation in https://github.com/concourse/concourse/blob/master/.github/CONTRIBUTING.md#running-concourse one should yield the following.

Given the token from ~/.flyrc:

$ curl 'http://localhost:8080/api/v1/teams/main/cc.xml' -H 'Authorization: Bearer YOUR_TOKEN'

<Projects>
  <Project activity="Sleeping" lastBuildLabel="5" lastBuildStatus="Success" 
           lastBuildTime="2018-11-05T20:02:57Z" name="example :: hello-world"
           webUrl="http://localhost:8080/teams/main/pipelines/example/jobs/hello-world"></Project>
</Projects>

I've assumed that an aborted build shall be marked as failed. Apologies for mixed tabs and spaces, I've trusted GoLand to choose the right thing to do, it might have failed me horribly.

The only way to currently access the endpoint is via a token retrieved from fly AFAIK (see above example). I wonder what Concourse wants to offer other apps when it comes to retrieving a long running session, preferably with easy user login. Currently I would see this as a blocker for integrating this new endpoint in my build monitor tools of choice.

pivotal-issuemaster · 2018-11-05T20:16:11Z

@cburgmer Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster · 2018-11-05T20:18:14Z

@cburgmer Thank you for signing the Contributor License Agreement!

atc/api/ccserver/get.go

+		activity = "Sleeping"
+	}
+
+	webUrl := s.createWebUrl([]string{


atc/api/ccserver/get.go

vito

Thanks for starting on this! 🙂 Left some feedback/requests inline.

cburgmer · 2018-11-19T21:33:17Z

Halfway through the changes I had to upgrade to Golang 1.11.2 to solve their issue 27925 (although I'm unsure whether this helped, or cherry-picking ce8743a). I'm now left with a broken ginkgo -r -p, as go insists on touching ./go.{mod,sum} and failing with task.go:8:2: unknown import path "gopkg.in/yaml.v2". I'm not sure how to resolve this now. Happy to rebase on master if this makes this problem go away.

vito · 2018-11-20T15:37:57Z

@cburgmer Not sure what version of Go you were on before, but if this is your first time with 1.11.x make sure it's cloned outside of your $GOPATH since projects using Go modules shouldn't be under that tree anymore.

It's also possible that ginkgo -r -p tried to fetch dependencies in parallel and corrupted your module cache (I think I've had that happen to me before). Make sure the repo is outside your $GOPATH, then try running go clean -modcache; go mod download; ginkgo -r -p to reset the fetched modules, fetch them serially (once), and then run the tests.

cburgmer · 2018-11-20T20:15:54Z

Let me know if there's more feedback on the code. As for the topic as such, we can probably continue the conversation on the original issue.

cburgmer · 2019-01-16T22:15:01Z

Just a note as the build has started failing: The merge of this PR is not blocked on the changes, but held back by the maintainers who only wish to maintain this feature should enough folks ask for it (hope I'm representing the sentiment correctly).

outdated - deferring approval to someone else

vito · 2019-01-17T16:19:55Z

@cburgmer Sorry for leaving this in limbo, we were on the fence about this and let it sit over the holidays. I've pinged @pivotal-jwinters to review, thanks for your patience!

jwntrs · 2019-01-17T17:33:15Z

@cburgmer did you solve your upstream auth issues with CCMenu?

cburgmer · 2019-01-17T22:04:33Z

@pivotal-jwinters I did not proceed while this PR was pending so far, but doing so now.

Imho this PR should be considered independently of whether CCMenu supports OAuth or not right now, as cc.xml is consumed by more than this one app. Also, do consider that this is a bit of a chicken and egg situation here for both products :)

As for logging in via OIDC into Concourse, I haven't found much documentation. I did reverse engineer fly's exchange. Is using the fly clientId the right step forward for now for fetching tokens?

jwntrs · 2019-01-18T15:14:59Z

Fair enough, just out of curiosity what other services use cc.xml?

As far as automating the OAuth flow, yeah, you can just use fly's public client.

At this point I think we can merge this, but just a heads up we're going to be revamping our APIs so things might change in the future.

cburgmer · 2019-01-18T17:30:28Z

Thanks. AFAIK CCTray started the format, CCMenu is the OSX implementation but loads of other bigger or smaller build monitors exist based on that format.
It happens that Concourse's own dashboard is quite slim, so there's less need for a monitor you might say. For me nothing trumps playing a 'sad trumpet' sound when the build fails for the team to improve on the MTTR.

vito · 2019-01-18T17:52:27Z

I'm not sure why but the DCO/WIP checks don't seem to have fired for this. @cburgmer would you mind rebasing and pushing to kick everything off again?

cburgmer · 2019-01-20T19:41:28Z

Sure. Rebased and pushed.

vito · 2019-01-21T17:40:10Z

@cburgmer DCO bot still isn't happy - looks like you need to run:

git rebase HEAD~13 --signoff

Signed-off-by: Christoph Burgmer <christoph.burgmer@gmail.com>

This matches my expectation with Jenkins. Signed-off-by: Christoph Burgmer <christoph.burgmer@gmail.com>

Signed-off-by: Christoph Burgmer <christoph.burgmer@gmail.com>

…E :: JOB' Signed-off-by: Christoph Burgmer <christoph.burgmer@gmail.com>

cburgmer · 2019-01-23T20:55:37Z

Did the sign-off. I cannot reproduce either failures from testflight and unit locally.

vito · 2019-01-24T15:11:43Z

@cburgmer Thanks! They look like flakes; I'll re-trigger.

vito

Merging - thanks again!

vito reviewed Nov 19, 2018

View reviewed changes

atc/api/ccserver/get.go Outdated Show resolved Hide resolved

vito reviewed Nov 19, 2018

View reviewed changes

atc/api/ccserver/get.go Outdated Show resolved Hide resolved

vito reviewed Nov 19, 2018

View reviewed changes

atc/api/ccserver/get.go

activity = "Sleeping"

}

webUrl := s.createWebUrl([]string{

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

vito reviewed Nov 19, 2018

View reviewed changes

atc/api/ccserver/get.go Outdated Show resolved Hide resolved

vito previously requested changes Nov 19, 2018

View reviewed changes

vito added the enhancement label Nov 19, 2018

vito mentioned this pull request Nov 19, 2018

atc: set BUILD_URL and BUILD_URL_SHORT metadata envvars #2747

Closed

vito requested a review from jwntrs January 17, 2019 16:18

jwntrs previously approved these changes Jan 18, 2019

View reviewed changes

cburgmer dismissed jwntrs’s stale review via 2f8e87f January 20, 2019 19:39

cburgmer force-pushed the master branch from 1c47270 to 2f8e87f Compare January 20, 2019 19:39

cburgmer added 4 commits January 21, 2019 20:26

Initial infra for cc.xml endpoint

c033592

Signed-off-by: Christoph Burgmer <christoph.burgmer@gmail.com>

Enable role to access new cc.xml endpoint

fdd80c1

Signed-off-by: Christoph Burgmer <christoph.burgmer@gmail.com>

Minimal CC.xml based on team's pipelines

bd36894

Signed-off-by: Christoph Burgmer <christoph.burgmer@gmail.com>

Include last build's status

0ee296f

Signed-off-by: Christoph Burgmer <christoph.burgmer@gmail.com>

cburgmer added 9 commits January 21, 2019 20:26

Include last build's label and buildTime

0c5288b

Signed-off-by: Christoph Burgmer <christoph.burgmer@gmail.com>

Include activity

5c6c50a

Signed-off-by: Christoph Burgmer <christoph.burgmer@gmail.com>

Include webUrl

df0ff41

Signed-off-by: Christoph Burgmer <christoph.burgmer@gmail.com>

Treat aborted builds as 'Exception', rather than an 'Unknown'.

c490aac

This matches my expectation with Jenkins. Signed-off-by: Christoph Burgmer <christoph.burgmer@gmail.com>

Fix build to return user visible number, not internal ID

a48ec9a

Signed-off-by: Christoph Burgmer <christoph.burgmer@gmail.com>

go fmt

b0146a6

Signed-off-by: Christoph Burgmer <christoph.burgmer@gmail.com>

Refactor, switch to db.Dashboard for a more performant query

29e52f5

Signed-off-by: Christoph Burgmer <christoph.burgmer@gmail.com>

Refactor, simplify by reading all values from the DashboardJob

8918124

Signed-off-by: Christoph Burgmer <christoph.burgmer@gmail.com>

Switch cc.xml project name schema to PIPELINE/JOB instead of 'PIPELIN…

b69edd8

…E :: JOB' Signed-off-by: Christoph Burgmer <christoph.burgmer@gmail.com>

cburgmer force-pushed the master branch from 2f8e87f to b69edd8 Compare January 21, 2019 19:26

vito approved these changes Jan 24, 2019

View reviewed changes

vito merged commit 889bb4a into concourse:master Jan 24, 2019

vito added this to the v5.0.0 milestone Mar 26, 2019

taylorsilva mentioned this pull request Sep 13, 2023

make cc.xml endpoint public, and only list public pipelines #8809

Merged

4 tasks

Uh oh!

Support for cc.xml #2759

Support for cc.xml #2759

Uh oh!

Conversation

cburgmer commented Nov 5, 2018

Uh oh!

pivotal-issuemaster commented Nov 5, 2018

Uh oh!

pivotal-issuemaster commented Nov 5, 2018

Uh oh!

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Uh oh!

vito left a comment

Choose a reason for hiding this comment

Uh oh!

cburgmer commented Nov 19, 2018

Uh oh!

vito commented Nov 20, 2018

Uh oh!

cburgmer commented Nov 20, 2018

Uh oh!

cburgmer commented Jan 16, 2019

Uh oh!

vito commented Jan 17, 2019

Uh oh!

jwntrs commented Jan 17, 2019

Uh oh!

cburgmer commented Jan 17, 2019

Uh oh!

jwntrs commented Jan 18, 2019

Uh oh!

cburgmer commented Jan 18, 2019

Uh oh!

vito commented Jan 18, 2019

Uh oh!

cburgmer commented Jan 20, 2019

Uh oh!

vito commented Jan 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cburgmer commented Jan 23, 2019

Uh oh!

vito commented Jan 24, 2019

Uh oh!

vito left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vito commented Jan 21, 2019 •

edited

Loading