Add support for newer AWS region on CloudFormation template #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there! We use Pivotal Tracker to provide visibility into what our team is working on. A story for this issue has been automatically created. The current status is as follows:
This comment, as well as the labels on the issue, will be automatically updated as the status in Tracker changes. |
|
Thanks! |
|
Manually merged onto |
shashwathi
pushed a commit
that referenced
this pull request
May 3, 2018
#1959 Submodule src/github.com/concourse/atc 310a311..97c9af1: > Add APIs to list destroying containers > Update marked destroy containers api without team context > Add API to report volumes to destroyed for a given worker > Add mark API > Merge pull request #271 from timrchavez/timrchavez/issue_1717 > Merge pull request #265 from SHyx0rmZ/set-content-type Submodule src/github.com/concourse/bin 6cd414a80..baac81ca9: > Add new runner for sweeping containers > Merge pull request #42 from osis/releasethequickstart Submodule src/github.com/concourse/topgun 7706c3b..e9251aa: > Enable debug to see more logs for Topgun Submodule src/github.com/concourse/tsa 62eb12d..5576ee1: > Add command to sync work status with ATC > Add tsa cmd to sweep containers Submodule src/github.com/concourse/worker 907ef55..85f0974: > Add sweeper runner to worker start command Signed-off-by: Rui Yang <ryang@pivotal.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New region support
I modified CloudFormation template to support newer AWS region. I added support for two missing regions:
Change NAT AMIs to use HVM virtualization type
I changed NAT AMIs to use HVM Virtualization Types, since PV(Paravirtual) virtualization type is not supported in new regions.
Change instance type
I changed instance type to
m4.largesince M3 type is not supported in new regions. Since it's almost twice expensive compared to existingm3.medium, I thought about using cheaper instance type liket2.medium, but since it doesn't have a consistent performance I decided to use standard M4 instance type instead. Feel free to modify it to another instance type.