Add /download-fly page for downloading the fly cli #9240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the CSS for the links into a LESS file, simplifying the elm code. Signed-off-by: Taylor Silva <dev@taydev.net>
and move around the order of the footer links Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
the version was hard to read Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
They now match the footer links for fly and docs on the dashboard page. Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
the cluster name was floating up instead of being centered Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
this is so we could show the full URL to download fly in the instructions. Thank you goes to this SO answer that provided a working example: https://stackoverflow.com/a/60609998 Another popular SO answer that came up was this one: https://stackoverflow.com/a/51664724 But it appears to not work as expected anymore. The ports method felt more reliable. Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
onFocus works when you click into the dropdown AND if you use tab to select the dropdown, which I believe is what folks that use accessability tools need. Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
|
OSX intel vs Mac? |
|
@analytically Are you talking about the naming of things in the dropdown? Not exactly sure what you mean by your statement or if you're suggesting a change... |
results in a higher contrast between the background and text Signed-off-by: Taylor Silva <dev@taydev.net>
|
I'm merging this now. Feel free to share any feedback here after I merge though. I'm happy to keep tweaking this page, though I think this current setup will be sufficient for everyone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
Concourse initially shipped with 3 variants of fly, one for each OS. With the next release, Concourse will now ship with 5 variants of fly; arm64 variants for Linux and macOS.
This PR adds a new page to the web UI, accessible at
/download-fly. This page contains a dropdown with all variants of fly that a user can download. Upon selecting a platform variant, a set of installation instructions is shown, along with a direct download link to fly.This page replaces our previous "download fly" links, which were three icon links to the 3 OS-specific variants of fly.
I also took the opportunity to add a link to the Concourse docs to the footer.
Footer
Before
After
Welcome Card
Before
After
Pipeline Footer
Before
After
Download Page
/download-flyInitial view:
Linux Platform selected (macOS is the same):
Windows Platform selected. The instructions also configure the Windows PATH for the user:
Fly Platform Options
I chose
x86_64andarm64as the cpu arch labels. I think most technical users will recognize those two cpu architecture labels. I chosex86_64overamd64because lexically "amd64" is looks similar to "arm64" and I wanted to avoid users clicking the wrong platform and wondering why they getexec formaterrors.