Improve idtoken credential provider compatibility (with AWS and Azure) #9224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Baumgarten <mail@dbaumgarten.net>
…bility with AWS Signed-off-by: Daniel Baumgarten <mail@dbaumgarten.net>
|
@taylorsilva Would you please take a look at this? Thanks :) |
taylorsilva
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
While working on the documentation for the new idtoken credential provider (and testing the provided examples) I discovered that it has compatibility issues with AWS and Azure.
This PR aims to fix these.
Azure requires the key-usage of the JWKs to be "sig". Currently it is set to "sign" (which is incorrect according to the RFC )
AWS requires more details in the OIDC-Discovery-Endpoint: https://docs.aws.amazon.com/IAM/latest/UserGuide/id_roles_providers_create_oidc.html#manage-oidc-provider-prerequisites
With the changes proposed in this PR, compatibility with AWS and Azure is ensured and the examples provided in the upcoming docs ( concourse/docs#563 ) work flawlessly.