Remove use of deprecated package github.com/pkg/errors #9216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there's an error in the You can run this locally to reproduce: I verified the error doesn't happen on |
Signed-off-by: Tom Godkin <tomgodkin@pm.me>
|
@taylorsilva thanks! Think I've fixed that now. |
|
@taylorsilva I did a quick scan and found a bunch more instances where |
|
Yeah there's a bunch of those. I'm fine with adding them to this PR, go for it 🙂 |
Signed-off-by: Tom Godkin <tomgodkin@pm.me>
|
@taylorsilva I think I found all the obvious ones |
taylorsilva
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
No functional change. This simply removes the
github.com/pkg/errorspackage in favour oferrors. The former has been deprecated for a while.There's a small bonus change - a demonstration of using the new
mapspackage to to simplify some code. There are probably other places in the code base where use ofmapsorsliceswould simplify things.Notes to reviewer
N/A