Restrict algorithms for host key exchange #9214
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylorsilva
requested changes
Jun 19, 2025
|
I can't access the logs of that failure. But in line with your comment before, I assume it's unrelated to my change. |
added 2 commits
June 20, 2025 15:33
Currently, "ssh-rsa" is offered as host key algorithm by TSA for worker registration on port 2222. This seems to be flagged at least by some security scanners as "using deprecated SHA1 cryptographic settings to communicate." This can be verified with: nmap -Pn --script ssh2-enum-algos -sV -p 2222 tsa.example.com And results in: | server_host_key_algorithms: (3) | rsa-sha2-256 | rsa-sha2-512 | ssh-rsa This can be addressed by specifying the allowed host key algorithms on the server side as outlined here: golang/go#52132 Signed-off-by: Robert Neumayer <robert.neumayer@proton.me>
Signed-off-by: Robert Neumayer <robert.neumayer@proton.me>
|
You are correct. There's been a single test in that test suite that's been flaking in CI when there's high CPU usage. Re-running it. Edit: Yup, it's green now. |
taylorsilva
approved these changes
Jun 20, 2025
|
@neumayer I added you to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, "ssh-rsa" is offered as host key algorithm by TSA for worker registration on port 2222. This seems to be flagged at least by some security scanners as "using deprecated SHA1 cryptographic settings to communicate."
This can be verified with:
nmap -Pn --script ssh2-enum-algos -sV -p 2222 tsa.example.com
And results in:
| server_host_key_algorithms: (3)
| rsa-sha2-256
| rsa-sha2-512
| ssh-rsa
This can be addressed by specifying the allowed host key algorithms on the server side as outlined here:
golang/go#52132
Changes proposed by this PR
closes #9212