runtime: Seccomp update #9173
Merged
runtime: Seccomp update #9173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed duplicate utimes * Add additional syscalls, matching what Docker/Containerd allow. Source: https://github.com/containerd/containerd/blob/main/contrib/seccomp/seccomp_default.go * Refactored the list of Syscalls by not using the AllowSyscall() func. This was a carry-over from following Garden/Guardian's implementation. I personally find it easier to manage the list of syscalls directly in the specs.LinuxSyscall struct. I left the syscalls that we specify args for as-is since I think the call to AllowSyscall() does make them easier to read. * Added clone3 and have it always returning ENOSYS, which is how users of it know to fallback to clone. See [here](containerd/containerd#5982) and [here](moby/moby#42681) for details Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
analytically
reviewed
Apr 2, 2025
| Names: []string{"clone3"}, | ||
| Action: specs.ActErrno, | ||
| ErrnoRet: &enosys, | ||
| }, |
There was a problem hiding this comment.
so it's not just allowing clone3 that would work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
Related to #9147
Fixes the issue we found on workers running on v5 of the linux kernel. When running
curlwe'd seegetaddrinfo() thread failed to start.The seccomp profile now has
clone3always returningENOSYSwhich glibc uses to know it should fallback to regularclone.Release Note