refactor: beingWatchedBuildEventChannelMap to use sync.Map #9161
+13
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the custom map implementation with mutex-based locking with Go's built-in sync.Map for improved concurrency handling. This change simplifies the code by: - Eliminating the need for manual RWMutex locking - Removing custom load/store/delete wrapper methods - Simplifying the Clean method to directly delete entries during iteration - Reducing memory allocations by avoiding temporary slices The functionality remains unchanged, but the implementation is now more concise and leverages Go's optimized concurrent map designed for high-read, low-write scenarios. Signed-off-by: Mathias Bogaert <mathias.bogaert@gmail.com>
f8db00d to
095953a
Compare
taylorsilva
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the custom map implementation with mutex-based locking with Go's built-in sync.Map for improved concurrency handling. This change simplifies the code by:
The functionality remains unchanged, but the implementation is now more concise and leverages Go's optimized concurrent map designed for high-read, low-write scenarios.