Skip to content

Conversation

analytically
Copy link
Contributor

  • Replace fmt.Sscanf with strconv.ParseUint for more efficient header parsing
  • Replace fmt.Sprintf("%d", id) with strconv.FormatUint for more efficient string conversion
  • Use Header().Set() to prevent duplicate headers
  • Add validation for http.Flusher type assertion
  • Improve error handling and logging context
  • Enhance code readability with consistent structure and formatting
  • Refactor event writing for better maintainability

- Replace fmt.Sscanf with strconv.ParseUint for more efficient header parsing
- Replace fmt.Sprintf("%d", id) with strconv.FormatUint for more efficient string conversion
- Use Header().Set() to prevent duplicate headers
- Add validation for http.Flusher type assertion
- Improve error handling and logging context
- Enhance code readability with consistent structure and formatting
- Refactor event writing for better maintainability

Signed-off-by: Mathias Bogaert <mathias.bogaert@gmail.com>
@analytically analytically requested a review from a team as a code owner March 29, 2025 12:18
@analytically
Copy link
Contributor Author

In combo with vito/go-sse#4

@taylorsilva taylorsilva moved this from Todo to In Progress in Pull Requests Jul 7, 2025
@taylorsilva taylorsilva merged commit ed9bdda into concourse:master Jul 8, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Pull Requests Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants