fix: add O_TRUNC flag when writing volume metadata file #9132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When writing metadata files, the code was using O_WRONLY|O_CREATE flags without O_TRUNC. This could cause file corruption when writing shorter content than what existed previously, as the remaining bytes from the old content would persist in the file. The fix adds O_TRUNC to ensure clean overwrites and maintain data integrity. Signed-off-by: Mathias Bogaert <mathias.bogaert@gmail.com>
taylorsilva
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing metadata files, the code was using O_WRONLY|O_CREATE flags without O_TRUNC. This could cause file corruption when writing shorter content than what existed previously, as the remaining bytes from the old content would persist in the file.
The fix adds O_TRUNC to ensure clean overwrites and maintain data integrity.