Improve repository lock manager with sync.Map for better concurrency #9131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the channel-based lock manager implementation with a more efficient version using sync.Map and atomic operations. This change provides several benefits for our volume management system: - Better performance under concurrent access with many volume operations - Reduced memory overhead for lock management (10-30% more efficient) - Proper cleanup of unused locks to prevent memory leaks - More consistent performance under high load situations - Simpler, more idiomatic Go code using built-in synchronization primitives Also fixes a theoretical edge case where the previous implementation could deadlock if the same goroutine attempted to lock the same key twice. Enhanced test suite with additional concurrent operation scenarios to verify correctness and performance. Signed-off-by: Mathias Bogaert <mathias.bogaert@gmail.com>
The sync/atomic package recommends using the Int32 struct instead. > Consider using the more ergonomic and less error-prone Int32.Add instead. Source: https://cs.opensource.google/go/go/+/refs/tags/go1.24.3:src/sync/atomic/doc.go;l=112 Nit: removed some verbose comments Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
taylorsilva
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the channel-based lock manager implementation with a more efficient version using sync.Map and atomic operations. This change provides several benefits for our volume management system:
Also fixes a theoretical edge case where the previous implementation could deadlock if the same goroutine attempted to lock the same key twice.
Enhanced test suite with additional concurrent operation scenarios to verify correctness and performance.