Support custom pipeline background image styling #9117
Conversation
|
Just a note-to-self, we should document these: https://github.com/concourse/docs/blob/70e8fd6ada55064074bc0d98666ca0219fa8d637/lit/docs/pipelines.lit#L109-L135 |
There was a problem hiding this comment.
Very nice! I think we can actually remove the background_opacity field because background_filter can be used to combine multiple filters like opacity(): https://developer.mozilla.org/en-US/docs/Web/CSS/filter
I made this filter:
background_filter: blur(5px)grayscale(100%)and got:
Adding opacity()
background_filter: blur(5px)grayscale(100%)opacity(50%)background_filter is all we really need :)
|
Currently opacity is set to 30%. If we'd just allow the filter to be set, what do we do with the default value? Not set it? People might expect it to be kept at 30% when just setting the filter? |
|
Having both opacity and filter is more flexible IMO. You can just set the image and opacity without thinking about filter. Or just image and filter, then an opacity of 30% is applied by default. |
|
Or, we move the default for opacity into the filter. |
Add support for configurable filter setting for pipeline background images. This enhances the visual customization options for pipelines by allowing users to set: - Custom filter effects (defaults to grayscale(100%) opacity(30%) as before) Signed-off-by: Mathias Bogaert <mathias.bogaert@gmail.com>
Add support for configurable filter setting for pipeline background images. This enhances the visual customization options for pipelines by allowing users to set:
Release Note
background_filteroption for pipeline background images which takes in string of CSS filters. Defaults to the current filtersopacity(30%) grayscale(100%)