Fix --team flag in order-pipelines command
#9102
Conversation
Signed-off-by: IvanChalukov <ichalukov@gmail.com>
There was a problem hiding this comment.
Not sure how to trigger the checks, but in any case I tested both scenarios with the old fly and your changes. The issue seems to be correctly handled by your change, that the old order-pipelines --alphabetical fetches the pipelines for the team it is currently in. I also confirmed that the code won't some how regress and break the functionality with order-pipelines --pipeline <some-pipeline-name> --pipeline <other-pipeline-name>. Thanks for the PR!
Screenshots from testing
|
Thanks for the validation @Kump3r. I am not sure how to trigger checks too. |
|
The checks trigger automatically. There's a Each job may take a while to report in but they will eventually. I made a change to the PRs pipeline: https://github.com/concourse/ci/blob/master/pipelines/pr.yml I've found if I have two or more PRs in-flight at the same time that the chance of tests flaking due to CPU stress greatly increases. I would add more PR workers but that's a Broadcom decision at this time. |
|
Thanks for the detailed explanation! I was wondering if I had missed something, but now I understand how it works. |
Changes proposed by this PR
The order-pipelines command with the --team option does not seem to work as expected. If you attempt to order pipelines from a team different from the one you are logged into, the operation will fail.
closes #9099
related to item in #5215
Notes to reviewer
Sample scenario: If you are logged into the main team (which has two pipelines: sample1 and sample2) and attempt to order pipelines from other-team (which has test1 and test2), the command will fail with the following error:
This suggests that the --team option is not correctly switching context to the specified team, causing the command to reference pipelines from the currently logged-in team instead.
Release Note
order-pipelinescommand with--teamOption