Fix: Preserve existing browser session during fly login
#9109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: IvanChalukov <ichalukov@gmail.com>
2ced2d2 to
9e830b3
Compare
|
This was next on my list of bugs to fix after v7.13.0 was out. Glad you beat me to it! |
taylorsilva
approved these changes
Mar 12, 2025
|
I'm more than happy to help! I have to admit, that one was tricky! |
|
@IvanChalukov you're my hero ❤️ ☆。 ★。 ☆ ★ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
This PR addresses the issue where logging in through the browser UI via
fly loginwould invalidate the existing browser session. The solution ensures that existing sessions remain active after the login process, preventing users from being logged out unexpectedly.closes #8868
csrf_tokento Elm appNotes to reviewer
The implementation enhances the process of sending the
csrf_tokento the Elm app, which then forwards the token to the web server. Previously, the value sent in theX-Csrf-Tokenheader was enclosed in quotes, like this:X-Csrf-Token: "redacted"This caused an error when comparing the CSRF token from the cookie and the header in the web server.
After the change, the
X-Csrf-Tokenheader now looks like:This adjustment ensures that the server can properly validate the token.
Release Note