atc: Various small fixes #9092
Merged
atc: Various small fixes #9092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix variable source diffs printing to stdout instead of provided writer
- Enhance practicallyDifferent to properly handle nil values
- nit: change interface{} to any, slowly modernizing go code
Signed-off-by: Mathias Bogaert <mathias.bogaert@gmail.com>
Co-authored-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Mathias Bogaert <mathias.bogaert@gmail.com>
Co-authored-by: Taylor Silva <dev@taydev.net>
The error message when encountering an invalid placement strategy incorrectly referenced the strategy variable (the accumulating result) rather than the specific invalid strategy string that caused the error. This resulted in misleading error messages that showed all strategies added so far instead of just the invalid one. Changed the error message to reference the specific invalid strategy string for clearer troubleshooting. nit: used newer `range int` feature in Go to make loop more readable Signed-off-by: Mathias Bogaert <mathias.bogaert@gmail.com> Co-authored-by: Taylor Silva <dev@taydev.net>
Replace mutex-based implementation with Go's atomic types to reduce contention and improve performance under high concurrency. This change eliminates lock overhead while maintaining thread safety. Signed-off-by: Mathias Bogaert <mathias.bogaert@gmail.com> Co-authored-by: Taylor Silva <dev@taydev.net>
…reds
Ensure the read lock is properly released using defer to guarantee thread safety
when iterating over credentials. This prevents a possible race condition if
multiple goroutines access the Tracker concurrently.
nit: modernize code by using any instead of interface{}
Signed-off-by: Mathias Bogaert <mathias.bogaert@gmail.com>
Co-authored-by: Taylor Silva <dev@taydev.net>
The scanner.scanResources method was creating a goroutine for each resource without any concurrency limits. For deployments with many resources, this could lead to resource exhaustion on the web node and possibly the database. This commit introduces a concurrency limit of 50 simultaneous resource checks. The implementation spawns 50 go routines and works through resources passed down a channel. Additionally, improved context handling was added to ensure proper cleanup when the scanner is being shut down or the context is otherwise canceled. This prevents orphaned goroutines from continuing to run after their parent process has been signaled to stop. These changes make the scanner more robust and predictable under high load while maintaining the existing parallel checking behavior. Signed-off-by: Mathias Bogaert <mathias.bogaert@gmail.com> Co-authored-by: Taylor Silva <dev@taydev.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
This is a collection of small fixes across various parts of the atc package.
Release Note
Tracker.IterateInterpolatedCredsSequenceGeneratorusing atomic types