worker runtime: make container deletion more robust #9090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We found that if a container wasn't correctly made, specifically if the `/etc/hosts` file of the container wasn't populated with the containers IP, container cleanup would fail with this error: ``` resume container traffic: error getting container IP: ip not found for container handle: 0ce036f8-aa2a-4bea-acbd-8ee48e5fa63b ``` We can ignore this error when deleting a container because it tells us there are no iptables rules to remove anyways. We can probably continue deleting the container and will delete it successfully. Signed-off-by: Taylor Silva <dev@taydev.net>
f5ec8a9 to
d24a423
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
We found that if a container wasn't correctly made, specifically if the
/etc/hostsfile of the container wasn't populated with the containers IP, container cleanup would fail with this error:We can ignore this error when deleting a container because it tells us there are no iptables rules to remove anyways. We can probably continue deleting the container and will delete it successfully.
Release Note
/etc/hostfile