fly: improve performance of fly watch #9097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd test Significantly improves performance of TimestampedWriter by implementing several optimizations: - Uses a buffer pool to eliminate allocations between Write calls - Processes input by segments between newlines rather than byte-by-byte - Optimizes timestamp formatting with direct byte manipulation - Pre-allocates and reuses buffers for newline tracking Benchmark improvements: - Eliminated allocations in most operations (0 allocs/op) - Medium inputs with timestamps improved from 445.8 ns/op to 168.2 ns/op - Large inputs with timestamps improved from 2284 ns/op to 871.2 ns/op - 6x faster for SetTimestamp operations - Maintains exact same output behavior Signed-off-by: Mathias Bogaert <mathias.bogaert@gmail.com> Co-authored-by: Taylor Silva <dev@taydev.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
Optimize TimestampedWriter for performance and reduced allocations. Added some tests as well.
Significantly improves performance of TimestampedWriter by implementing several optimizations:
Benchmark improvements:
Release Note
fly watch