Fix bug in maxValidFromFile using hardcoded path #9082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The maxValidFromFile function was incorrectly using the hardcoded uidMap path regardless of the filename parameter passed to it. This caused the MaxValidIds method to always read from /proc/self/uid_map twice instead of reading from both uid_map and gid_map files. Fixed by modifying maxValidFromFile to properly use the fname parameter both when opening the file and when generating error messages. Signed-off-by: Mathias Bogaert <mathias.bogaert@gmail.com> Co-authored-by: Taylor Silva <dev@taydev.net>
analytically
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
The
maxValidFromFile()function was incorrectly using theconst uidMapvar regardless of the filename parameter passed to it. This caused the MaxValidIds method to always read from/proc/self/uid_maptwice instead of reading from both uid_map and gid_map files.Fixed by modifying maxValidFromFile to properly use the fname parameter both when opening the file and when generating error messages.
Release Note