Skip to content

fix the policy-checker-handler logger session name #9081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

fix the policy-checker-handler logger session name #9081

merged 1 commit into from
Feb 25, 2025

Conversation

aliculPix4D
Copy link
Contributor

fix the policy-checker-handler logger session name

Very minor log name correction.

Currently in the logs one sees:

{"timestamp":"2024-10-09T10:05:31.196402292Z","level":"error","source":"atc","message":"atc.policy-checker.policy-checker","data":{"error":"OPA server: connecting: Post "[http://localhost:8181/v1/data/concourse/decision\](http://localhost:8181/v1/data/concourse/decision%5C)": dial tcp [::1]:8181: connect: connection refused","session":"134","user-msg":"policy-checker: unreachable or misconfigured"}}

note the msg: atc.policy-checker.policy-checker. The atc.policy-checker is already there. So the session name should just be handler.

With the proposed change we will see: atc.policy-checker.handler

@aliculPix4D
atc/api/policy-checker-handler: fix the logger session name
d26a29c 
Signed-off-by: aliculPix4D <aleksandar.licul@pix4d.com>
@aliculPix4D aliculPix4D requested a review from a team as a code owner February 24, 2025 14:24
@aliculPix4D aliculPix4D mentioned this pull request Feb 24, 2025
Merged
marco-m-pix4d
marco-m-pix4d approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@marco-m-pix4d marco-m-pix4d left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(is this going to upstream on purpose? Ah, it is the one you mentioned missing?)

@aliculPix4D
Copy link
Contributor Author

aliculPix4D commented Feb 24, 2025 •
edited
Loading

(is this going to upstream on purpose? Ah, it is the one you mentioned missing?)

Yes, its on purpose... we had this merged for few months now, but I forgot to include it in the PRs to upstream... (I noticed it now, since we are syncing with upstream master and I got conflict on this line)

@taylorsilva taylorsilva merged commit 997aa65 into concourse:master Feb 25, 2025
11 checks passed
@aliculPix4D aliculPix4D deleted the policy-checker-correct-handler-name branch February 25, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylorsilva taylorsilva taylorsilva approved these changes

+1 more reviewer

@marco-m-pix4d marco-m-pix4d marco-m-pix4d approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aliculPix4D @taylorsilva @marco-m-pix4d