atc: exec: ignore task input/output paths that reference parent directories #9078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behaviour of this was changed back in 7.5.0 by #6597 Previously only relative paths were allowed. No tests were added to handle these new cases. In testing this I also found that paths with parent directories were also allowed and would work. You'd get the input mounted above the task's CWD. This seems like a bad thing to encourage so I've locked things down to only allow absolute and relative paths. Allowing parent directories seems like an easy footgun for users to fall onto. We now have test coverage for: - Allowing absolute paths in task inputs/outputs - Ignoring paths with parent directory references in them Signed-off-by: Taylor Silva <dev@taydev.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
The behaviour of this was changed back in 7.5.0 by #6597 (2ba0164) and was never properly captured in our release notes. It kinda snuck in with everything else in that PR.
Previously only relative paths were allowed. No tests were added to handle these new cases. In testing this I also found that paths with parent directories were also allowed and would work; You'd get the input mounted above the task's CWD. This seems like a bad thing to encourage so I've locked things down to only allow absolute and relative paths. Allowing parent directories seems like an easy footgun for users to fall onto.
We now have test coverage for:
Release Note
../) will be treated as relative paths and no parent directory traversal will occur.