make sure to drop item from secret cache after default duration if calculated duration is equal or less than 0 #9049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes the secret cache not to be cleared for the object and it is saved for ever. Checking the itemDuration if it is greater than 0 fixed this issue and sets the default duration. Also changed the test duration as the tests needed 5 seconds, no they are 1 second. Signed-off-by: Carlo Blohm <carlo.blohm@solarisbank.de>
taylorsilva
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Thanks for the PR @carlo-blohm! Sorry it took a while getting to it. Thanks for including a test as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
closes #8705
The current implementation causes the secret cache not to be cleared for the object and it is saved for ever.
Checking the itemDuration if it is greater than 0 fixed this issue and sets the default duration.
Also changed the test duration as the tests needed 5 seconds, now they are done in 1 second.
Notes to reviewer
hope the shortened timing does not break CI or other non local systems
Release Notes