Skip to content

Conversation

aliculPix4D
Copy link
Contributor

@aliculPix4D aliculPix4D commented Oct 10, 2024

Log policy checker error messages.

  • minor improvements to OPA agent error messages
  • atc: log errors returned by policy checker agent

This will ensure that:

  • we return a meaningful error message to the Concourse end user (policy-checker: unreachable or misconfigured)
  • Concourse operator/maintainer has all the required information in logs and can configure automated alerting on ERROR logs...

Originally, we wanted to go a step further and also log the success and log the actual policy checker decision and reason but that turned out to be too complicated with the current code to be done in a clean way. To improve this situation, in the future we plan to open a new issue to start the discussion on the proposed changes first.

Release Note

  • Log detailed OPA error messages in web nodes logs and show a friendlier error message to the end user

…A server

Signed-off-by: aliculPix4D <aleksandar.licul@pix4d.com>
…hecker

Signed-off-by: aliculPix4D <aleksandar.licul@pix4d.com>
@aliculPix4D aliculPix4D requested a review from a team as a code owner October 10, 2024 16:04
@marco-m-pix4d marco-m-pix4d self-requested a review October 11, 2024 07:37
@taylorsilva
Copy link
Member

Wow didn't realize how many PRs you guys had opened! I'll get around to them once 7.12.0 is out

@taylorsilva taylorsilva added this to the v7.13.0 milestone Dec 4, 2024
Copy link
Member

@taylorsilva taylorsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for these small PRs. I really love seeing folks make small improvements like this.

@taylorsilva taylorsilva merged commit 6a70c34 into concourse:master Jan 8, 2025
11 checks passed
@aliculPix4D aliculPix4D deleted the atc-policy-checker-handler-log-errors branch January 9, 2025 10:06
@aliculPix4D
Copy link
Contributor Author

Thanks for these small PRs. I really love seeing folks make small improvements like this.

Thanks for taking care of these PRs...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants