Skip to content

Conversation

xtremerui
Copy link
Contributor

docker-compose is deprecated. We should use docker compose instead. Luckily concourse/unit installs docker-ce that should include the compose plugin already.

@xtremerui xtremerui added the misc label Apr 17, 2024
@xtremerui xtremerui added this to the v7.12.0 milestone Apr 17, 2024
@xtremerui xtremerui requested a review from a team as a code owner April 17, 2024 21:37
@xtremerui xtremerui force-pushed the fix-docker-compose-integration-test branch 2 times, most recently from 8700082 to 4743367 Compare April 18, 2024 16:14
docker-compose is deprecated. We should use docker compose instead.
Luckily concourse/unit installs docker-ce that should include the
compose plugin already

- projet name has to be lowercase
- version in docker-compose file is not needed
- --filter is replaced with --status

Signed-off-by: Rui Yang <rui.yang@broadcom.com>
@xtremerui xtremerui force-pushed the fix-docker-compose-integration-test branch 4 times, most recently from 1dd47ba to b93d364 Compare April 21, 2024 04:35
We were waiting volumes from previous deployment to be GCed to make
sure they are not used for new build. In previous version, these tests
were flaky already by the reason that there is no garantee that new
volumes haven't being created before old volumes are deleted.

Now with newer version of Concourse, the check of base resource type
'mock' happens right after the web node started so the method
'waitForVolumeGC' no longer works as the volume list will always contain
those new volumes for the resouce type check.

Instead, we now keep a record of old volumes and we just need to make
sure after new deployment, those old volumes are GCed i.e. volume
listing should not contain any old volume from previous deployment.

The waiting time is also increased to 5 min as in the downgrade test,
the volumes of the one-off build requires longer time to be GCed.

Signed-off-by: Rui Yang <rui.yang@broadcom.com>
@xtremerui xtremerui force-pushed the fix-docker-compose-integration-test branch from b93d364 to 8c94749 Compare April 22, 2024 03:08
Co-authored-by: Wayne Adams <wayne.adams@broadcom.com>
Co-authored-by: Rui Yang <ruiya@vmware.com>
Signed-off-by: Wayne Adams <wayne.adams@broadcom.com>
@wayneadams wayneadams force-pushed the fix-docker-compose-integration-test branch from e1f6076 to ba99863 Compare April 22, 2024 20:44
by configuring the one off build grace period, the downgrade test
should run fast enough that original wait time is sufficient.

Also discover that the "panic test timeout 600s" is caused by the
default go test timeout (10min), in a way that setting the wait time
in testify.require.Eventually won't matter. To increase the default
timeout, do "go test --timeout xxx". By configuring the one off grace
period, we don't need to use that flag.

Signed-off-by: Rui Yang <rui.yang@broadcom.com>
@xtremerui xtremerui merged commit bcebfe9 into master Apr 23, 2024
@xtremerui xtremerui deleted the fix-docker-compose-integration-test branch April 23, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants