Skip to content

Conversation

xtremerui
Copy link
Contributor

Changes proposed by this PR

closes #8722

  • done
  • todo

Notes to reviewer

Release Note

  • Fix a bug of fly builds command that shows pipeline/job not found when both --team and --pipeline/--job are provided.

Signed-off-by: Rui Yang <ruiya@vmware.com>
@xtremerui xtremerui added the bug label Oct 14, 2023
@xtremerui xtremerui added this to the v7.11.0 milestone Oct 14, 2023
@xtremerui xtremerui requested a review from a team as a code owner October 14, 2023 02:29
Copy link
Contributor

@wayneadams wayneadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this works

wadams in ~/workspace/concourse on issue/8722-fly-team-builds λ fly -t local builds --team main --pipeline hello
id  name                   status     start                     end                       duration  team  created by
3   hello/hello-world/2.1  succeeded  2023-10-03@11:56:38-0700  2023-10-03@11:56:42-0700  4s        main  test      
2   hello/hello-world/2    aborted    2023-10-03@11:55:58-0700  2023-10-03@11:56:00-0700  2s        main  test      
1   hello/hello-world/1    succeeded  2023-10-03@11:53:38-0700  2023-10-03@11:54:08-0700  30s       main  test 

@xtremerui xtremerui merged commit 754ce3d into master Oct 16, 2023
@xtremerui xtremerui deleted the issue/8722-fly-team-builds branch October 16, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fly -t TARGET builds -p pipeline --team OTHER_TEAM returns pipeline/job not found
2 participants