Skip to content

Emitting "latest_completed_build_status" gauge from prometheus #8826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 11, 2023
Merged

Emitting "latest_completed_build_status" gauge from prometheus #8826

merged 5 commits into from
Oct 11, 2023

Conversation

wayneadams
Copy link
Contributor

@wayneadams wayneadams commented Sep 27, 2023 •
edited
Loading

Changes proposed by this PR

  • Ensures that the guage gets emitted
  • Ensure that the gauge has latest completed build status information

Notes to reviewer

Currently, this metric is emitting the following attributes alongside the gauge: jobName, pipelineName, teamName. Is there any other metadata about the job or build that should be emitted?

This is how the metric will show up in the Prometheus dashboard:

Screenshot 2023-10-03 at 11 58 02 AM

Release Note

  • Add concourse_builds_latest_completed_build_status metric
    • Guage = 0 for success
    • Guage = 1 for failure
    • Guage = 2 for aborted
    • Guage = 3 for error

@xtremerui xtremerui force-pushed the add-guage-for-job-status branch from 52c0f44 to af719e7 Compare September 29, 2023 18:51
@wayneadams wayneadams marked this pull request as ready for review October 3, 2023 19:19
@wayneadams wayneadams requested a review from a team as a code owner October 3, 2023 19:19
@wayneadams wayneadams changed the title Emitting "job_status" gauge from prometheus Emitting "jlatest_completed_build_status" gauge from prometheus Oct 3, 2023
@wayneadams wayneadams changed the title Emitting "jlatest_completed_build_status" gauge from prometheus Emitting "latest_completed_build_status" gauge from prometheus Oct 3, 2023
wayneadams and others added 5 commits October 10, 2023 15:29
@wayneadams
Emitting "job_status" gauge from prometheus
547fd05 
Co-authored-by: Rui Yang <ruiya@vmware.com>
Signed-off-by: Wayne Adams <wadams@vmware.com>
@wayneadams
WIP: emitting job status when saving
51cbd83 
Signed-off-by: Wayne Adams <wadams@vmware.com>
@wayneadams
impl of getting latest completed build id in job
14ef234 
Co-authored-by: Wayne Adams <wadams@vmware.com>
Signed-off-by: Rui Yang <ruiya@vmware.com>
fix test panic and race
6a256c1 
Signed-off-by: Rui Yang <ruiya@vmware.com>
@wayneadams
Change metric name to be more descriptive
9edbf68 
Co-authored-by: Rui Yang <ruiya@vmware.com>
Signed-off-by: Wayne Adams <wadams@vmware.com>
@xtremerui xtremerui force-pushed the add-guage-for-job-status branch from af6f264 to 9edbf68 Compare October 10, 2023 19:29
@wayneadams wayneadams merged commit ebeefc5 into master Oct 11, 2023
@wayneadams wayneadams deleted the add-guage-for-job-status branch October 11, 2023 18:13
This was referenced Oct 11, 2023
Merged
Merged
@wayneadams wayneadams added this to the v7.11.0 milestone Oct 11, 2023
@xtremerui xtremerui mentioned this pull request Dec 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v7.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wayneadams @xtremerui