Fixes cf authentication fails on 7.9.1 #8696 #8806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ensures that prior "cf" named teams also work with "cloudfoundry" naming from DEX Co-authored-by: Rui Yang <ruiya@vmware.com> Signed-off-by: Wayne Adams <wadams@vmware.com>
098c153 to
5dce1d5
Compare
|
Hi all, thank you for addressing this issue. We appreciate your efforts in resolving it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also ensures that prior "cf" named teams also work with "cloudfoundry" naming from DEX
Changes proposed by this PR
closes #8696
Notes to reviewer
The changes in
skymarshal/dexserver/dexserver.goare not covered in unit tests. This is because theskycmd.GetConnectors()is not exposable to the public.We did run an integration scenario locally by 1) using fly to create a
cflabeled team-auth, and 2) logging on using a version of DEX that's configured forcloudfoundrylabels. Our mapping worked.Release Note