Revert "feat(atc): cache streamed volumes and try to get by looking for local cache" #6659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenbh
approved these changes
Mar 11, 2021
@clarafu It's absolution ok because nobody wants an unstable 7.1.0. I will resubmit the PR and call for more reviews. Are error logs of ATC available for those error screen shots? I have no any non-Linux worker, if the problem only exists on non-Linux worker, then I'll hard to reproduce and fix. |
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #6495
After deploying this change to our ci deployment there were many build failures such as the following screenshots below
@evanchaoli unfortunately we are not going to include the pr in the v7.1.0 release, we will need to do some much more thorough testing and reviewing of the pr with probably some other concourse team members that have more context than me about the workings of containers/volumes.