Limit configured by limit-active-tasks is not respected and more tasks can land on a worker
#6216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
05f0cb2 to
e641e4c
Compare
…-active-tasks is not respected and more tasks can land on a worker Fixes the bug where more tasks than the choosen limit can land on the same worker, even though limit-active-task container placement strategy option with max-active-task-per-worker is selected. This fix ensures that chosenWorker = client.pool.FindOrChooseWorkerForContainer returns nil if the first task already acquired the lock. concourse#6206 Signed-off-by: aliculPix4D <aleksandar.licul_ext@pix4d.com>
e641e4c to
c3d40a3
Compare
muntac
approved these changes
Nov 9, 2020
There was a problem hiding this comment.
@aliculPix4D Thanks for taking the time to dig deep into such a hard to reproduce bug!
limit-active-tasks is not respected and more tasks can land on a worker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR accomplish?
Bug Fix
Fixes the bug where more tasks than the chosen limit can land on the same worker, even though limit-active-task container placement strategy option with max-active-task-per-worker is selected.
This fix ensures that
chosenWorker = client.pool.FindOrChooseWorkerForContainerreturns nil if the first task already acquired the lock.closes #6206
Changes proposed by this PR:
Notes to reviewer:
Release Note
Contributor Checklist
Reviewer Checklist
BOSH and
Helm packaging; otherwise, ignored for
the integration
tests
(for example, if they are Garden configs that are not displayed in the
--helptext).