libui 0.4.1 #5251

grafikrobot · 2021-04-17T15:03:00Z

Specify library name and version: libui/0.4.1

Migration from Bincrafters to CCI.

WARNING: I'm submitting this even though it fails locally as a basis to point out problems with the downstream dependency chain.

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

grafikrobot · 2021-04-17T16:03:33Z

As I feared this failed to build. When I try this locally the the key problem is that it fails to find a appropriate gtk/3.24.24 build available in CCI on the default configuration for Arch Linux with gcc-10. When I try this locally and comparing the settings set I see the following differences between local and remote:

[grafik@Coqui all]$ diff settings-local.txt settings-remote.txt -U 2
--- settings-local.txt  2021-04-16 19:03:01.804000000 -0500
+++ settings-remote.txt 2021-04-16 19:07:16.258033329 -0500
@@ -55,6 +55,4 @@
 jbig:fPIC=True
 jbig:shared=False
-libdeflate:fPIC=True
-libdeflate:shared=False
 libelf:fPIC=True
 libelf:shared=False
@@ -81,17 +79,9 @@
 libtiff:jbig=True
 libtiff:jpeg=libjpeg
-libtiff:libdeflate=True
 libtiff:lzma=True
 libtiff:shared=False
-libtiff:webp=True
 libtiff:zlib=True
-libtiff:zstd=True
 libuuid:fPIC=True
 libuuid:shared=False
-libwebp:fPIC=True
-libwebp:near_lossless=True
-libwebp:shared=False
-libwebp:swap_16bit_csp=False
-libwebp:with_simd=True
 libxml2:c14n=True
 libxml2:catalog=True
@@ -165,6 +155,4 @@
 xz_utils:shared=False
 zlib:fPIC=True
-zlib:minizip=deprecated
+zlib:minizip=False
 zlib:shared=False
-zstd:fPIC=True
-zstd:shared=False

Obviously build differences are to be expected from time to time. But in this case what would be the natural client work around to use --build results it the build of one of the dependencies attempting to sudo install a system package. Probably stemming from one of the "*/system" dependencies in this build chain. Something which is clearly not acceptable.

recipes/libui/all/conanfile.py

recipes/libui/all/test_package/conanfile.py

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

madebr · 2021-04-17T18:27:35Z

Obviously build differences are to be expected from time to time. But in this case what would be the natural client work around to use --build results it the build of one of the dependencies attempting to sudo install a system package. Probably stemming from one of the "*/system" dependencies in this build chain. Something which is clearly not acceptable.

Looking at https://conan.io/center/gtk?version=3.24.24&tab=configuration&os=Linux, I think the gtk package is outdated.
conan.io/center lists zlib:minizip=False where this one looks for zlib:minizip=deprecated.

recipes/libui/all/conanfile.py

prince-chrismc · 2021-04-20T01:27:19Z

recipes/libui/all/conandata.yml

@@ -0,0 +1,4 @@
+sources:
+  "0.4.1":


This version does not match the tag... we typically avoid pre-releases too... but it's barely active 💭

According to the tags, there was not a stable release so far. So we might want to interpret alpha4.1 as 0.4.1 🤔

How about 4.1-alpha?
See https://semver.org/#spec-item-9

That quote says..

A pre-release version MAY be denoted by appending a hyphen and a series of dot separated identifiers immediately following the patch version.

Key word is "MAY". I.e. it's not required. And since there was never a 4.1 release, or any other stable version, it seems superfluous to tag it with "-alpha". Although changing it from "0.4.1" to "4.1" could be argued.

But to be honest.. I've essentially given up on CCI. And I would be perfectly fine if this never got merged. So if someone else wants to keep pushing this recipe along, go for it.

recipes/libui/all/conanfile.py

prince-chrismc

Might it be a good idea to put this in a subfolder? I see they completely changed the build system so large parts won't be re-used if there's ever a new release or we make a virtual one

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

grafikrobot · 2021-04-20T16:15:24Z

Locally, with the rebuilt gtk which it downloads, I still get this:

Not updating system_requirements. CONAN_SYSREQUIRES_MODE=verify
Running: sudo pacman -S --noconfirm xtrans

This is for Manjaro, aka ArchLinux.

conan-center-bot · 2021-04-20T16:49:48Z

All green in build 7 (75880b2572ab9b1e75884a9d52bee68af69a97f8):

libui/0.4.1@:
All packages built successfully! (All logs)

Croydon · 2021-04-20T16:58:42Z

This is expected as it requires xorg/system. System packages in its nature do really on system packages, that is also why they should be avoided whenever possible, but that is not reasonably possible in the case of xorg

prince-chrismc

LGTM... this one cause use a reviewer with more knowledge =)

Initial attempt at libui for CCI.

f90ed36

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Apr 17, 2021

madebr reviewed Apr 17, 2021

View reviewed changes

recipes/libui/all/conanfile.py Outdated Show resolved Hide resolved

madebr reviewed Apr 17, 2021

View reviewed changes

recipes/libui/all/test_package/conanfile.py Outdated Show resolved Hide resolved

recipes/libui/all/test_package/conanfile.py Outdated Show resolved Hide resolved

grafikrobot and others added 3 commits April 17, 2021 13:06

Update recipes/libui/all/conanfile.py

448bb30

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

Update recipes/libui/all/test_package/conanfile.py

960c05d

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

Update recipes/libui/all/test_package/conanfile.py

ac64819

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

This comment has been minimized.

Sign in to view

grafikrobot mentioned this pull request Apr 17, 2021

Migration efforts of recipes in single recipe repositories bincrafters/community#1380

Open

Croydon mentioned this pull request Apr 19, 2021

GTK rebuild #5262

Merged

4 tasks

prince-chrismc reviewed Apr 20, 2021

View reviewed changes

recipes/libui/all/conanfile.py Outdated Show resolved Hide resolved

prince-chrismc reviewed Apr 20, 2021

View reviewed changes

recipes/libui/all/conanfile.py Outdated Show resolved Hide resolved

prince-chrismc reviewed Apr 20, 2021

View reviewed changes

grafikrobot and others added 2 commits April 20, 2021 10:57

Update recipes/libui/all/conanfile.py

3d919b3

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

Update recipes/libui/all/conanfile.py

5643430

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

This comment has been minimized.

Sign in to view

Fix syntax error.

75880b2

conan-center-bot removed the Failed label Apr 20, 2021

SSE4 requested a review from uilianries April 21, 2021 06:07

prince-chrismc approved these changes May 8, 2021

View reviewed changes

github-actions bot mentioned this pull request May 8, 2021

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

conan-center-bot requested a review from lasote May 10, 2021 11:57

uilianries approved these changes May 10, 2021

View reviewed changes

SSE4 approved these changes May 12, 2021

View reviewed changes

conan-center-bot merged commit d5786a0 into conan-io:master May 12, 2021

CroydonBot deleted the libui branch May 12, 2021 09:24

libui 0.4.1 #5251

libui 0.4.1 #5251

Uh oh!

Conversation

grafikrobot commented Apr 17, 2021

Uh oh!

This comment has been minimized.

grafikrobot commented Apr 17, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

madebr commented Apr 17, 2021

Uh oh!

Uh oh!

prince-chrismc Apr 20, 2021

Choose a reason for hiding this comment

Uh oh!

Croydon Apr 20, 2021

Choose a reason for hiding this comment

Uh oh!

madebr May 8, 2021

Choose a reason for hiding this comment

Uh oh!

grafikrobot May 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

prince-chrismc left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

grafikrobot commented Apr 20, 2021

Uh oh!

conan-center-bot commented Apr 20, 2021

Uh oh!

Croydon commented Apr 20, 2021

Uh oh!

prince-chrismc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

grafikrobot May 8, 2021 •

edited

Loading