Freeglut #5238
Merged
Freeglut #5238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
901450a to
295c7a6
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
baa0605 to
9644adc
Compare
This comment has been minimized.
This comment has been minimized.
uilianries
reviewed
Apr 16, 2021
Comment on lines
27
to
38
| /* | ||
| glutInit(&argc,argv); | ||
| glutInitDisplayMode(GLUT_DEPTH | GLUT_DOUBLE | GLUT_RGBA); | ||
| glutInitWindowPosition(100,100); | ||
| glutInitWindowSize(320,320); | ||
| glutCreateWindow("Lighthouse3D - GLUT Tutorial"); | ||
|
|
||
| // register callbacks | ||
| glutDisplayFunc(renderScene); | ||
|
|
||
| // enter GLUT event processing cycle | ||
| glutMainLoop();*/ |
There was a problem hiding this comment.
Maybe this?
Suggested change
| /* | |
| glutInit(&argc,argv); | |
| glutInitDisplayMode(GLUT_DEPTH | GLUT_DOUBLE | GLUT_RGBA); | |
| glutInitWindowPosition(100,100); | |
| glutInitWindowSize(320,320); | |
| glutCreateWindow("Lighthouse3D - GLUT Tutorial"); | |
| // register callbacks | |
| glutDisplayFunc(renderScene); | |
| // enter GLUT event processing cycle | |
| glutMainLoop();*/ | |
| glutInit(&argc,argv); |
There was a problem hiding this comment.
I'm not sure yet why, but I get a runtime error when calling glutInit on WSL (it passes on windows), with the following output failed to open display ''
There was a problem hiding this comment.
WSL is missing the support to run graphics ... the API is there but it fails AFAIK
Been a while since I had this problem, but last time I used the usual headless CI flags to trick it to run from my travis CI scripts doing electron
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
prince-chrismc
previously approved these changes
Apr 16, 2021
madebr
reviewed
Apr 16, 2021
| def requirements(self): | ||
| self.requires("opengl/system") | ||
| self.requires('glu/system') | ||
| if self.settings.os == "Linux": |
There was a problem hiding this comment.
Untested. Since you're the BSD specialist, you have the last word on this.
If accepted, this change should probably be applied to other places in this recipe.
Suggested change
| if self.settings.os == "Linux": | |
| if self.settings.os in ("Linux", "FreeBSD"): |
recipes/freeglut/all/conanfile.py
Outdated
| if self.settings.os == "Windows": | ||
| if not self.options.shared: | ||
| self.cpp_info.components['freeglut_'].defines.append("FREEGLUT_STATIC=1") | ||
| self.cpp_info.components['freeglut_'].defines.append("FREEGLUT_LIB_PRAGMAS=0") |
There was a problem hiding this comment.
Is this macro also required for mingw?
#pragma warning is only used by msvc.
There was a problem hiding this comment.
might be required for Intel/Clang, not sure about MinGW
SSE4
previously approved these changes
Apr 17, 2021
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
6b95548
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
madebr
reviewed
Apr 22, 2021
madebr
reviewed
Apr 27, 2021
|
All green in build 16 (
|
prince-chrismc
approved these changes
Apr 27, 2021
madebr
approved these changes
Apr 27, 2021
SSE4
approved these changes
Apr 29, 2021
AlvaroFS
pushed a commit
to AlvaroFS/conan-center-index
that referenced
this pull request
May 7, 2021
* add freeglut/3.2.1 this is a port of https://github.com/bincrafters/conan-freeglut * remove useless option * use standard libdirs * fix fpic * disable macos * test package as C project * disable gcc 10 * disable clang 11 too * Apply suggestions from code review Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * set cmake and pkg-config names also, fixup tabs and missing import in test recipe * increase test coverage * fix test * Update recipes/freeglut/all/conanfile.py Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> * Update recipes/freeglut/all/conanfile.py Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> * Update recipes/freeglut/all/conanfile.py Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * freeglut: change download to SourceForge + reformatting * cache cmake Co-authored-by: Chris Mc <prince.chrismc@gmail.com> Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> Co-authored-by: Croydon <git@cr0ydon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: freeglut/3.2.1
this is a port of https://github.com/bincrafters/conan-freeglut
conan-center hook activated.