imagemagick 7.0.11-14 #5849

Renari · 2021-06-10T21:40:37Z

Specify library name and version: ImageMagick/7.0.11-14

For #5502, copied from bincrafters/conan-imagemagick

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

CLAassistant · 2021-06-10T21:40:41Z

All committers have signed the CLA.

recipes/imagemgagick/all/conanfile.py

recipes/imagemgagick/all/test_package/conanfile.py

recipes/imagemgagick/all/test_package/test_package.cpp

recipes/imagemgagick/all/conanfile.py

madebr · 2021-06-10T22:54:21Z

Thanks for the recipe!
It looks like a great start.
Please ask for EAP in #4 and let's see what c3i (=CI infrastructure) has to say about this.

recipes/imagemgagick/all/conanfile.py

Croydon · 2021-06-11T08:27:02Z

Copied from https://github.com/bincrafters/conan-imagemagick as mentioned by me in #5502. Please mention this in the PR description to provide direct credits 🙂

Renari · 2021-06-14T14:00:21Z

Does anyone know of a package that downloads multiple sources using conandata.yml that I can use for a reference?

SpaceIm · 2021-06-14T14:05:15Z

cryptopp: source code and build system files split in 2 archives
cspice: 1 archive per os/arch/compiler

Renari · 2021-06-14T18:17:07Z

I'm not sure why this is failing on windows, since the error given appears to be missing Visual C++ libraries. However on Linux the includes fail due to:

    def _copy_pkg_config(self, name):
        if name not in self.deps_cpp_info.deps:
            return
        root = self.deps_cpp_info[name].rootpath
        pc_dir = os.path.join(root, 'lib', 'pkgconfig')
        pc_files = glob.glob('%s/*.pc' % pc_dir)
        if not pc_files:
            pc_files = glob.glob('%s/*.pc' % root)
        for pc_name in pc_files:
            new_pc = os.path.join('pkgconfig', os.path.basename(pc_name))
            self.output.info('copying .pc file %s' % os.path.basename(pc_name))
            shutil.copy(pc_name, new_pc)
            prefix = tools.unix_path(root) if os.name == 'nt' else root
            tools.replace_prefix_in_pc_file(new_pc, prefix)

This is trying to copy pc files from other libraries lib directory to configure automake, CCI recipes do not ship these files and I'm not sure what the alternative is.

Renari · 2021-06-14T20:41:46Z

c:\j\w\buildsinglereference@3.conan\data\imagemagick\7.0.11-14__\build\e9c0c93677ff85fb899e6dbfa8bdb4a1d1209f98\visualmagick\configure\stdafx.h(17): fatal error C1083: Cannot open include file: 'afxwin.h': No such file or directory [C:\J\w\BuildSingleReference@3.conan\data\imagemagick\7.0.11-14__\build\e9c0c93677ff85fb899e6dbfa8bdb4a1d1209f98\VisualMagick\configure\configure.vcxproj]

I'm not sure how to fix this, build is working for me on linux.

Renari · 2021-06-28T12:51:20Z

It looks like afxwin.h is a MFC file which is not shipped in the express version of Visual C++. I'm not sure if it can be disabled.

Renari · 2021-06-28T12:55:33Z

https://github.com/ImageMagick/ImageMagick-Windows

It looks like MFC is required, I'm not sure there's anything I can do to add that.

prince-chrismc

Overwhelming this looks good just a couple follow-up questions

recipes/imagemagick/all/conanfile.py

prince-chrismc · 2021-09-26T01:27:14Z

recipes/imagemagick/all/conanfile.py

+        for patch in self.conan_data.get("patches", {}).get(self.version, {}):
+            tools.patch(**patch)


The only patch is "remove deps" should it not be applied on all systems?

I'm not sure this is from the original bincrafters recipe, I haven't changed anything related to windows builds since they don't currently work.

prince-chrismc · 2021-09-26T01:28:56Z

recipes/imagemagick/all/conanfile.py

+
+            msbuild = MSBuild(self)
+            # fatal error C1189: #error:  Please use the /MD switch for _AFXDLL builds
+            msbuild.build_env.flags = ["/MD"]


I've never worked with windows builds

Is the code provided function on your system? It seems odd to merge a lot of complicated logic if it's not somewhat working

recipes/imagemagick/all/test_package/test_package.cpp

add conandata.yml change source and build subfolders to property methods additional library options use 'with_' prefix os.name -> tools.os_info.is_windows remove fPIC for shared build add support for libjpeg turbo crossbuilding support for test package remove disabling of pango change homepage to imagemagick.org specify run_environment=True download sources using conandata.yml correct typo in directory name run install during package step move visualmagick to be a subelement of sources in conandata.yml change handling of visualmagick in conandata.yml move some tools.replace_in_file calls to patches remove license export remove shebang update minimum cmake version remove verbose make files add with_pango option remove cstdlib import remove pc file generation add pkg_config generator correct some test keys remove etc, pkgconfig and .la files remove share directory correct path for file removal Add an option to control compilation of djvu support. add components sourced from pc files add pkg_config names split pkg_config names into separate declarations use requires to remove some duplicate component declarations add FIXME for modeling FindImageMagick move pthread to system_libs Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> update libtiff to 4.3.0 update openexr to 2.5.7 throw invalid configuration exception for windows due to mfc remove unused shutil import workaround for xorg/system includes conan-io#6880 remove conan topic Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> change TOGO to FIXME Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> add info for modifying path Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> remove settings from cross_building Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> remove _is_mingw_windows property condense source acquisition Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> condense source acquisition for visualmagick Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> convert test package to c implementation replace self._major with tools.Version(self.version).major remove copying pdb clean up arguments use msvs_toolset add newer visual studio versions formatting define visualmagick_version fix args redefinition removing some configure arguments format visualmagick_version Update recipes/imagemagick/all/conanfile.py Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> Update recipes/imagemagick/all/conanfile.py Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> finish converting test package to run using C move configuration check to validate method Revert "finish converting test package to run using C" This reverts commit 4f9ab48. finish converting test package to run using C fixed refactor issue where this modified the automake recipe

conan-center-bot · 2021-09-27T13:29:33Z

All green in build 46 (74591351d70d432de2be514c75b9a04beec2ae0c):

imagemagick/7.0.11-14@:
All packages built successfully! (All logs)

prince-chrismc · 2021-09-27T15:00:45Z

Please do not force push 🙏 GitHub forces us to restart the review which is not fun!

prince-chrismc

🤞 we can short out the windows section soon

Renari · 2021-09-27T15:19:21Z

Please do not force push GitHub forces us to restart the review which is not fun!

Sorry I was rebasing and squashing all the commits so it shows up nicely on master.

jgsogo · 2021-09-27T15:22:23Z

Please do not force push GitHub forces us to restart the review which is not fun!

Sorry I was rebasing and squashing all the commits so it shows up nicely on master.

On the merge commit to master we squash all commits from the branch so only the title is visible in the history... but thanks for taking care of it (although it has some disadvantages for the review process).

Renari · 2021-09-27T15:25:28Z

Please do not force push GitHub forces us to restart the review which is not fun!

Sorry I was rebasing and squashing all the commits so it shows up nicely on master.

On the merge commit to master we squash all commits from the branch so only the title is visible in the history... but thanks for taking care of it (although it has some disadvantages for the review process).

![image](https://user-images.githubusercontent.com/1406456/134937440-3bf6930e-4723-4e67-aeea-4fb6494917e5.png)

Ah good to know I'll refrain from doing it in the future then.

prince-chrismc · 2021-09-27T15:44:20Z

Ah good to know I'll refrain from doing it in the future then.

Thank you and keep up the great contributions!

This comment has been minimized.

Sign in to view

conan-center-bot added the No Beta user label Jun 10, 2021

madebr reviewed Jun 10, 2021

View reviewed changes

SpaceIm suggested changes Jun 10, 2021

View reviewed changes

recipes/imagemgagick/all/conanfile.py Outdated Show resolved Hide resolved

recipes/imagemgagick/all/conanfile.py Outdated Show resolved Hide resolved

madebr reviewed Jun 10, 2021

View reviewed changes

recipes/imagemgagick/all/conanfile.py Outdated Show resolved Hide resolved

madebr reviewed Jun 10, 2021

View reviewed changes

recipes/imagemgagick/all/conanfile.py Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

conan-center-bot removed the No Beta user label Jun 14, 2021

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Jun 14, 2021

This comment has been minimized.

Sign in to view

Renari force-pushed the imagemagick branch from 8b2faa5 to d3ff6f7 Compare June 14, 2021 20:45

This comment has been minimized.

Sign in to view

conan-center-bot requested a review from czoido August 25, 2021 12:00

conan-center-bot requested review from uilianries and jgsogo September 6, 2021 12:00

conan-center-bot requested review from memsharded and danimtb September 15, 2021 11:58

This comment has been minimized.

Sign in to view

SSE4 previously approved these changes Sep 25, 2021

View reviewed changes

prince-chrismc mentioned this pull request Sep 25, 2021

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

prince-chrismc reviewed Sep 26, 2021

View reviewed changes

Renari dismissed SSE4’s stale review via 0ff05db September 27, 2021 12:20

ghost mentioned this pull request Sep 27, 2021

[service] Potentially conflicting recipes #3571

Closed

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Sep 27, 2021

Renari force-pushed the imagemagick branch from 0ff05db to 452819c Compare September 27, 2021 12:24

Renari force-pushed the imagemagick branch from 452819c to 7459135 Compare September 27, 2021 12:24

Renari requested a review from SSE4 September 27, 2021 12:36

conan-center-bot removed the Failed label Sep 27, 2021

SSE4 approved these changes Sep 27, 2021

View reviewed changes

prince-chrismc approved these changes Sep 27, 2021

View reviewed changes

jgsogo approved these changes Sep 27, 2021

View reviewed changes

conan-center-bot merged commit 3583871 into conan-io:master Sep 27, 2021

Renari mentioned this pull request Sep 27, 2021

[request] Imagemagick/7.0.11-14 #5502

Closed

Renari deleted the imagemagick branch September 28, 2021 18:06

		for patch in self.conan_data.get("patches", {}).get(self.version, {}):
		tools.patch(**patch)

imagemagick 7.0.11-14 #5849

imagemagick 7.0.11-14 #5849

Uh oh!

Conversation

Renari commented Jun 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Jun 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

madebr commented Jun 10, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Croydon commented Jun 11, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Renari commented Jun 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SpaceIm commented Jun 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Renari commented Jun 14, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Renari commented Jun 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Renari commented Jun 28, 2021

Uh oh!

Renari commented Jun 28, 2021

Uh oh!

This comment has been minimized.

prince-chrismc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

prince-chrismc Sep 26, 2021

Choose a reason for hiding this comment

Uh oh!

Renari Sep 27, 2021

Choose a reason for hiding this comment

Uh oh!

prince-chrismc Sep 26, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

conan-center-bot commented Sep 27, 2021

Uh oh!

prince-chrismc commented Sep 27, 2021

Uh oh!

prince-chrismc left a comment

Choose a reason for hiding this comment

Uh oh!

Renari commented Sep 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Renari commented Jun 10, 2021 •

edited

Loading

CLAassistant commented Jun 10, 2021 •

edited

Loading

Renari commented Jun 14, 2021 •

edited

Loading

SpaceIm commented Jun 14, 2021 •

edited

Loading

Renari commented Jun 14, 2021 •

edited

Loading

Renari commented Sep 27, 2021 •

edited

Loading

Renari commented Sep 27, 2021 •

edited

Loading