Added Lua 5.3.5 recipe #545

GavinNL · 2019-12-26T19:37:58Z

Library name and version: lua/5.3.5

Copied the recipe from sqlite and then modified.

Tested on Linux Mint 19.2 GCC7 using the following

export CONAN_HOOK_ERROR_LEVEL=40
conan create . 5.3.5@test/test

CMakeLists.txt file copied with permission from https://github.com/helmesjo/conan-lua

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

conan-center-bot · 2019-12-26T19:38:10Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

claassistantio · 2019-12-26T19:38:19Z

All committers have signed the CLA.

uilianries · 2019-12-26T21:26:11Z

Hi @GavinNL ! Thanks for your contribution, could you please sign your name on the issue #4 You need be a Beta user to continue this PR.

GavinNL · 2019-12-26T21:31:14Z

Hi @GavinNL ! Thanks for your contribution, could you please sign your name on the issue #4 You need be a Beta user to continue this PR.

Done!

uilianries · 2019-12-26T21:46:00Z

recipes/lua/all/CMakeLists.txt

@@ -0,0 +1,87 @@
+cmake_minimum_required(VERSION 2.8.12)


Where did you find this Cmake file? Did you try the port in vcpkg? Some definitions that I saw there in vcpkg are not here in this file. Unfortunately, the Lua's author don't want native cmake support.

https://github.com/helmesjo/conan-lua

Should I use the one from vcpkg instead?

Yes, please. It's more maintained and contain extra features, as compiler definitions.

@GavinNL ping

uilianries · 2019-12-26T21:48:10Z

recipes/lua/all/conanfile.py

+from distutils.dir_util import copy_tree
+
+
+license = """================================================================================


Do not copy the license directly in the recipe. Extract it from src/lua.h. Take a look here to understand how to extract: https://docs.conan.io/en/latest/howtos/extract_licenses_from_headers.html

uilianries · 2019-12-26T21:48:33Z

recipes/lua/all/conanfile.py

+"""
+
+class LuaConan(ConanFile):
+    no_copy_source = True


Suggested change

no_copy_source = True

Use no_copy_source only for header-only

uilianries · 2019-12-26T21:48:58Z

recipes/lua/all/conanfile.py

+    exports_sources = ["CMakeLists.txt"]
+
+    _source_subfolder = "source_subfolder"
+    _build_subfolder = "build_subfolder"


Suggested change

_build_subfolder = "build_subfolder"

You are not using this.

uilianries · 2019-12-26T21:49:49Z

recipes/lua/all/patches/0001-Remove-architecture-check-from-CMake-package.patch

@@ -0,0 +1,34 @@
+From 3a53ea1f692251c052bf0b99cbc484c4f6641a8d Mon Sep 17 00:00:00 2001


Where did you find this patch?

Errr...that shouldn't be there...I copied the whole recipe from GLM I believe

uilianries · 2019-12-26T22:03:42Z

recipes/lua/all/conanfile.py

+
+    def package_info(self):
+        self.cpp_info.libs = tools.collect_libs(self)
+        self.cpp_info.includedirs.append("include/lua")


Suggested change

self.cpp_info.includedirs.append("include/lua")

self.cpp_info.includedirs.append("include/lua")

if self.settings.os == "Linux":

self.cpp_info.system_libs = ["m"]

Take a look in the makefile

conan-center-bot · 2019-12-26T23:02:50Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2019-12-27T14:20:47Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

Signed-off-by: Uilian Ries <uilianries@gmail.com>

uilianries · 2019-12-27T17:49:25Z

@GavinNL I've added cpp as optional, please take a look: GavinNL#1

conan-io#545 Add cpp build as option

conan-center-bot · 2019-12-27T18:10:44Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

uilianries

LGTM

- lua.hpp is no included when compile_as_cpp is turned on. - needed to modify the test_package CMakeLists file to include a preprocessor definition when compiling with compile_as_cpp turned on

conan-center-bot · 2019-12-27T18:50:37Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

uilianries

~~remove explicit COMPILE_AS_CPP from cmake and conanfile in test package~~

uilianries

Forget about, LGTM.

conan-center-bot · 2020-01-10T11:59:04Z

All green in build 6 (9edaedfa3b156016937846f5fa3b3e6890301b9c)! 😊

lua/5.3.5: Generated 82 packages. All logs here

conan-center-bot · 2020-01-15T16:48:50Z

All green in build 7 (9edaedfa3b156016937846f5fa3b3e6890301b9c)! 😊

lua/5.3.5: Generated 82 packages. All logs here

uilianries · 2020-01-16T18:34:46Z

@SSE4 Will be really happy reviewing this PR, he loves Lua! 🙊

Added Lua recipe

126f526

conan-center-bot added the No Beta user label Dec 26, 2019

uilianries requested changes Dec 26, 2019

View reviewed changes

Fixed PR suggestions

530d787

Using the VCPKG CMakeLists file

6cdeb62

conan-io#545 Add cpp build as option

0975ae9

Signed-off-by: Uilian Ries <uilianries@gmail.com>

Merge pull request #1 from uilianries/lua

b3d8970

conan-io#545 Add cpp build as option

uilianries previously approved these changes Dec 27, 2019

View reviewed changes

Updated Test package lists file

9edaedf

- lua.hpp is no included when compile_as_cpp is turned on. - needed to modify the test_package CMakeLists file to include a preprocessor definition when compiling with compile_as_cpp turned on

GavinNL dismissed uilianries’s stale review via 9edaedf December 27, 2019 18:50

uilianries requested changes Dec 27, 2019

View reviewed changes

uilianries approved these changes Dec 27, 2019

View reviewed changes

danimtb removed the No Beta user label Jan 10, 2020

danimtb requested a review from SSE4 January 10, 2020 12:04

madebr mentioned this pull request Jan 11, 2020

Add premake/5.0.0-alpha14 #647

Merged

4 tasks

danimtb assigned GavinNL Jan 16, 2020

SSE4 approved these changes Jan 28, 2020

View reviewed changes

danimtb approved these changes Jan 29, 2020

View reviewed changes

danimtb assigned danimtb and unassigned GavinNL Jan 29, 2020

danimtb merged commit 729af65 into conan-io:master Jan 29, 2020

GavinNL deleted the lua-5.3.5 branch March 7, 2020 20:31

		from distutils.dir_util import copy_tree


		license = """================================================================================

		@@ -0,0 +1,34 @@
		From 3a53ea1f692251c052bf0b99cbc484c4f6641a8d Mon Sep 17 00:00:00 2001

Added Lua 5.3.5 recipe #545

Added Lua 5.3.5 recipe #545

Uh oh!

Conversation

GavinNL commented Dec 26, 2019

Uh oh!

conan-center-bot commented Dec 26, 2019

Uh oh!

claassistantio commented Dec 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

uilianries commented Dec 26, 2019

Uh oh!

GavinNL commented Dec 26, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

conan-center-bot commented Dec 26, 2019

Uh oh!

conan-center-bot commented Dec 27, 2019

Uh oh!

uilianries commented Dec 27, 2019

Uh oh!

conan-center-bot commented Dec 27, 2019

Uh oh!

uilianries left a comment

Choose a reason for hiding this comment

Uh oh!

conan-center-bot commented Dec 27, 2019

Uh oh!

uilianries left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

uilianries left a comment

Choose a reason for hiding this comment

Uh oh!

conan-center-bot commented Jan 10, 2020

Uh oh!

conan-center-bot commented Jan 15, 2020

Uh oh!

uilianries commented Jan 16, 2020

Uh oh!

Uh oh!

claassistantio commented Dec 26, 2019 •

edited

Loading

uilianries left a comment •

edited

Loading