Skip to content

Conversation

toge
Copy link
Contributor

@toge toge commented Aug 18, 2025

Summary

Changes to recipe: plutovg/1.3.0

Motivation

There are lots of new features since 1.0.0.

Details

https://github.com/sammycage/plutovg/releases/tag/v1.3.0


Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always, thanks! I have a few questions with the patch - I've also removed old unused versions

#include <assert.h>
+#if !defined(_WIN32)
+ #if defined(__linux__)
+ #define __USE_POSIX
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions:

  • Where does this bit come from?
  • Is the missing header reported upstream already?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry.
I'm investigating these modification.
It is not a valid patch because plutovg-font.c has already include limits.h.
https://github.com/sammycage/plutovg/blob/v1.3.0/source/plutovg-font.c#L699

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the reason.

  • -std=c11 doesn't define _USE_POSIX
  • -std=gnu11 defines _USE_POSIX

I try to modify meson.build to use gnu11.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@toge toge marked this pull request as draft August 22, 2025 07:06
@toge toge marked this pull request as ready for review August 22, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants