Add systemd/system #2468

intelligide · 2020-08-08T23:01:43Z

Specify library name and version: systemd/system

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

conan-center-bot · 2020-08-08T23:05:32Z

Some configurations of 'libudev/system' failed in build 1 (5de1674425c90033eacb2cbd41cdc15afe0ca0e1):

Linux x86_64, Release, gcc 5, libstdc++
Access to all the logs

conan-center-bot · 2020-08-08T23:26:49Z

All green in build 2 (ba43f57358ffc43aed6777c54230bba3d1723bb7)! 😊

libudev/system: Generated 1 packages. All logs here

conan-center-bot · 2020-08-09T00:04:24Z

All green in build 3 (ca46158448516bb6ca62a1053ff1af7a8d89769d)! 😊

libudev/system: Generated 1 packages. All logs here

Croydon · 2020-08-09T04:02:47Z

Since udev got merged into systemd directly and on some distros we need to install the systemd package to get udev... is libudev/system still the best name?

jgsogo · 2020-08-10T08:33:45Z

Since udev got merged into systemd directly and on some distros we need to install the systemd package to get udev... is libudev/system still the best name?

@Croydon , Thinking from the consumer POV, do you think it would be better..?

self.requires("systemd/system")

---

find_package(systemd)
target_link_libraries(mylibrary PUBLIC systemd::libudev)

than

self.requires("libudev/sysstem")
---
find_package(libudev)
target_link_libraries(mylibrary PUBLIC libudev::libudev)

Croydon · 2020-08-13T16:26:42Z

A quick random search on the web shows that some projects have created custom FindUDev.cmake files in the meantime. This probably rather supports having libudev as a separate package

However, this might originate from the time before the merge into systemd and could be seen as legacy.

Another point to consider: we might want/need more systemd libs in the future. Do we create one system package for each of them or one systemd package with different targets?

jgsogo · 2020-08-14T09:19:17Z

cc/ @SSE4 and @czoido

We agree that thanks to components we can get any desired granularity when consuming these _system _ libraries, but I would say that the same granularity is desired when installing the actual system packages that provide these libraries. I mean, if we add a lot of them to the same systemd/system package then all of them will be installed when we just want to consume one of them (of course we could use options to choose which ones to install, but then we will get conflicts downstream for overlapping graphs). This is my argument to vote for different references, but I haven't think too much or read about this specific topic.

recipes/libudev/all/conanfile.py

recipes/libudev/all/test_package/CMakeLists.txt

Co-authored-by: Uilian Ries <uilianries@gmail.com>

conan-center-bot · 2020-09-04T14:03:43Z

All green in build 4 (20cab58511280f80717f383956f678f30147a5e3)! 😊

libudev/system: Generated 1 packages. All logs here

recipes/libudev/all/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

uilianries

LGTM

uilianries · 2020-11-11T16:23:43Z

Let's push this one, there is a PR requesting libudev and libusb can be updated too.

conan-center-bot · 2020-11-11T16:24:03Z

All green in build 5 (0221efb86e50c56855fd986daa6bc026caa89d37)! 😊

libudev/system: Generated 1 packages. All logs here

intelligide · 2020-11-11T19:22:31Z

I did it.

conan-center-bot · 2020-11-11T19:27:58Z

Some configurations of 'systemd/system' failed in build 6 (9e490190c5b7dde8255071195ac3276d1e181aef):

Linux x86_64, Release, gcc 4.9, libstdc++
Access to all the logs

recipes/systemd/all/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

conan-center-bot · 2020-11-11T20:31:00Z

Some configurations of 'systemd/system' failed in build 7 (5ec6c1172a6bdd0e6b520e0815b54a2ba8c421f2):

Linux x86_64, Release, gcc 4.9, libstdc++
Access to all the logs

Croydon · 2020-11-11T23:28:44Z

Ubuntu Trusty does not have a systemd-dev package, only a systemd package:

https://pkgs.org/search/?q=systemd
https://ubuntu.pkgs.org/14.04/ubuntu-updates-main-amd64/systemd_204-5ubuntu20.31_amd64.deb.html

I'm not sure which Ubuntu versions changed that, if we could find that out that would be good.

If not, 16.04 Xenial has it for sure. So let's make a switch for <= 16.04 to install systemd instead of systemd-dev

ericLemanissier · 2020-11-30T14:45:30Z

Sorry if someone already brought this out, but doesn't this recipe collide with #3556 ?

Anyway, while checking some other pr for system packages, I noticed that this one fails on these distros:

ericLemanissier · 2020-12-03T10:06:18Z

@intelligide now that #3556 is merged, do we still need this one ? if yes, we probably want to rename it libsystemd/system

uilianries · 2020-12-03T19:14:42Z

Yes! We need libudev. #3556 is only about libsystemd, here all libs under systemd are incorporated.

recipes/systemd/all/conanfile.py

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>

conan-center-bot · 2020-12-03T19:55:02Z

Some configurations of 'systemd/system' failed in build 8 (bdd8d86d87366682d503dc7f329080fea0d376ee):

Linux x86_64, Release, gcc 4.9, libstdc++
Access to all the logs

ericLemanissier · 2020-12-03T20:19:51Z

recipes/systemd/all/conanfile.py

+            if tools.os_info.with_yum or tools.os_info.with_dnf:
+                packages = ["systemd", "systemd-libs", "libudev-devel"]
+            elif tools.os_info.with_apt:
+                packages = ["libsystemd-dev", "libudev-dev", "systemd"]


Suggested change

packages = ["libsystemd-dev", "libudev-dev", "systemd"]

packages = ["libudev-dev", "systemd"]

if not (tools.os_info.linux_distro == "ubuntu" and tools.os_info.os_version < "15"):

packages.append("libsystemd-dev")

fix ubuntu trusty, which does not have libsystemd-dev

ericLemanissier · 2020-12-03T20:24:12Z

recipes/systemd/all/conanfile.py

+        self.info.header_only()
+
+    def package_info(self):
+        self._fill_cppinfo_from_pkgconfig("systemd", "libsystemd")


Suggested change

self._fill_cppinfo_from_pkgconfig("systemd", "libsystemd")

if not (tools.os_info.linux_distro == "ubuntu" and tools.os_info.os_version < "15"):

self._fill_cppinfo_from_pkgconfig("libsystemd", "libsystemd")

systemd.pc contains only variables. do we really want systemd.pc or libsystemd.pc ?
also, ubuntu trusty has no package providing libsystemd.pc nor libsystemd.so. The alternative would be to raise a ConanInvalidConfiguration on this distro.

Croydon · 2020-12-04T14:54:26Z

Also as I expressed my concerns here #3556 (comment) & here #3556 (comment) - isn't there a huge chance that this might lead to conflicts? How API and ABI stable is libsystemd?

I think for other CCI recipes we should only rely on systemd/system

uilianries · 2020-12-04T15:28:45Z

If we want to avoid conflicts, we can use provides feature.

Croydon · 2020-12-04T15:36:33Z

I didn't mean conflicts between Conan packages. I mean a conflict between the Conan package libsystemd/<version> and a system wide installed libsystemd/systemd, hence I believe we should only use systemd/system as a dependency in other Conan packages, NOT libsystemd/<version>

stale · 2021-01-03T16:14:48Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2021-02-02T16:23:12Z

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

Add libudev/system

5de1674

conan-center-bot added the Failed label Aug 8, 2020

intelligide marked this pull request as draft August 8, 2020 23:11

libudev: add test

ba43f57

conan-center-bot removed the Failed label Aug 8, 2020

intelligide marked this pull request as ready for review August 8, 2020 23:28

intelligide mentioned this pull request Aug 8, 2020

Add sfml/2.5.1 #2467

Closed

4 tasks

libudev: fix test

ca46158

SSE4 previously approved these changes Aug 9, 2020

View reviewed changes

SSE4 requested review from jgsogo and uilianries August 9, 2020 10:12

jgsogo mentioned this pull request Aug 10, 2020

Remove system_requirements exception for libusb conan-io/hooks#158

Merged

jgsogo requested a review from czoido August 14, 2020 09:19

uilianries requested changes Sep 4, 2020

View reviewed changes

recipes/libudev/all/conanfile.py Outdated Show resolved Hide resolved

recipes/libudev/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved

Apply suggestions from code review

20cab58

Co-authored-by: Uilian Ries <uilianries@gmail.com>

intelligide dismissed SSE4’s stale review via 20cab58 September 4, 2020 13:58

uilianries self-requested a review September 8, 2020 14:12

uilianries requested changes Nov 11, 2020

View reviewed changes

Apply suggestions from code review

0221efb

Co-authored-by: Uilian Ries <uilianries@gmail.com>

uilianries approved these changes Nov 11, 2020

View reviewed changes

Change libudev to systemd

9e49019

conan-center-bot added the Failed label Nov 11, 2020

uilianries requested changes Nov 11, 2020

View reviewed changes

recipes/systemd/all/conanfile.py Outdated Show resolved Hide resolved

recipes/systemd/all/conanfile.py Outdated Show resolved Hide resolved

Apply suggestions from code review

5ec6c11

Co-authored-by: Uilian Ries <uilianries@gmail.com>

uilianries previously approved these changes Dec 3, 2020

View reviewed changes

ericLemanissier suggested changes Dec 3, 2020

View reviewed changes

recipes/systemd/all/conanfile.py Outdated Show resolved Hide resolved

recipes/systemd/all/conanfile.py Outdated Show resolved Hide resolved

uilianries self-requested a review December 3, 2020 19:44

Apply suggestions from code review

bdd8d86

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>

intelligide dismissed uilianries’s stale review via bdd8d86 December 3, 2020 19:49

ericLemanissier reviewed Dec 3, 2020

View reviewed changes

This was referenced Dec 15, 2020

Add libudev/virtual #904

Closed

libusb: Use systemd/system #905

Closed

stale bot added the stale label Jan 3, 2021

stale bot closed this Feb 2, 2021

Croydon mentioned this pull request Oct 9, 2021

Add system libudev #7611

Merged

4 tasks

uilianries mentioned this pull request Oct 9, 2021

Add systemd (libraries + binaries) #7623

Closed

4 tasks

-                packages = ["libsystemd-dev", "libudev-dev", "systemd"]
+                packages = ["libudev-dev", "systemd"]
+                if not (tools.os_info.linux_distro == "ubuntu" and tools.os_info.os_version < "15"):
+                    packages.append("libsystemd-dev")

	self._fill_cppinfo_from_pkgconfig("systemd", "libsystemd")
	if not (tools.os_info.linux_distro == "ubuntu" and tools.os_info.os_version < "15"):
	self._fill_cppinfo_from_pkgconfig("libsystemd", "libsystemd")

Add systemd/system #2468

Add systemd/system #2468

Uh oh!

Conversation

intelligide commented Aug 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

conan-center-bot commented Aug 8, 2020

Uh oh!

conan-center-bot commented Aug 8, 2020

Uh oh!

conan-center-bot commented Aug 9, 2020

Uh oh!

Croydon commented Aug 9, 2020

Uh oh!

jgsogo commented Aug 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Croydon commented Aug 13, 2020

Uh oh!

jgsogo commented Aug 14, 2020

Uh oh!

Uh oh!

Uh oh!

conan-center-bot commented Sep 4, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

uilianries left a comment

Choose a reason for hiding this comment

Uh oh!

uilianries commented Nov 11, 2020

Uh oh!

conan-center-bot commented Nov 11, 2020

Uh oh!

intelligide commented Nov 11, 2020

Uh oh!

conan-center-bot commented Nov 11, 2020

Uh oh!

Uh oh!

Uh oh!

conan-center-bot commented Nov 11, 2020

Uh oh!

Croydon commented Nov 11, 2020

Uh oh!

ericLemanissier commented Nov 30, 2020

Uh oh!

ericLemanissier commented Dec 3, 2020

Uh oh!

uilianries commented Dec 3, 2020

Uh oh!

Uh oh!

Uh oh!

conan-center-bot commented Dec 3, 2020

Uh oh!

ericLemanissier Dec 3, 2020

Choose a reason for hiding this comment

Uh oh!

ericLemanissier Dec 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Croydon commented Dec 4, 2020

Uh oh!

uilianries commented Dec 4, 2020

Uh oh!

Croydon commented Dec 4, 2020

Uh oh!

stale bot commented Jan 3, 2021

Uh oh!

stale bot commented Feb 2, 2021

Uh oh!

Uh oh!

intelligide commented Aug 8, 2020 •

edited

Loading

jgsogo commented Aug 10, 2020 •

edited

Loading

ericLemanissier Dec 3, 2020 •

edited

Loading