-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[boost] Add check for coroutine support for Cobalt build #24237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[boost] Add check for coroutine support for Cobalt build #24237
Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!
Conan v1 pipeline ✔️All green in build 1 (
Conan v2 pipeline ✔️
All green in build 1 (
|
Hooks produced the following warnings for commit b32826aboost/1.84.0@#cebe00ff95d4cca0de315413d38cfdbb
boost/1.82.0@#47e7b0c3ddccedf39a3baf57a7e61801
boost/1.85.0@#a68463169d04e86aceb21ffa9deb6858
boost/1.80.0@#01c3b3a2d87b06a4be07d5eec01d1e46
boost/1.79.0@#8583133e0f46a9cbe971429a079d9997
boost/1.81.0@#ee027e2185d9866c04a467e740944810
boost/1.78.0@#69e33e0544f0ae2566374b65faf04d97
boost/1.76.0@#b09dfcb8e7bb81aba974feb35d6434e7
boost/1.83.0@#f9d7f54f9095af0977b068c5e1164748
boost/1.75.0@#64c2a73b9139ef4d6d05adc6f0032051
boost/1.74.0@#2fbf528641c9070b864c5234cd34a372
boost/1.73.0@#f5add4aa1dbb2df28b6435771bff69d5
boost/1.77.0@#75a56271aca8cad3e4d528d396cdb3e3
boost/1.72.0@#88944683840c00840368a80c705d3aab
boost/1.71.0@#1a41b9ce40ce6ac0820955cc21aa97f5
|
As we don't use C++20 in the CI, here is a build log with Cobalt built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @uilianries !!!
Specify library name and version: boost/1.84.0
Since Boost 1.84.0, the new library Cobalt was introduced and requires not only C++20, but also concepts and coroutines:
This PR adds a new check to validate the compiler version if has support to coroutines, based on https://en.cppreference.com/w/cpp/compiler_support#cpp20
fixes #24216