Skip to content

Add llvm-openmp/9.0.1 recipe #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 28, 2020
Merged

Add llvm-openmp/9.0.1 recipe #1075

merged 5 commits into from
Apr 28, 2020

Conversation

vvilpas
Copy link
Contributor

@vvilpas vvilpas commented Mar 9, 2020

Specify library name and version: llvm-openmp/9.0.1

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Contributor

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

madebr
madebr reviewed Mar 9, 2020
View reviewed changes
Copy link
Contributor

@madebr madebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@Morwenn Maybe this could have helped #897?

@vvilpas @madebr
Apply suggestions from code review
a07a8da 
Co-Authored-By: Anonymous Maarten <madebr@users.noreply.github.com>
@conan-center-bot
Copy link
Contributor

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

@vvilpas vvilpas mentioned this pull request Mar 9, 2020
Merged
2 tasks
@Morwenn
Copy link
Contributor

Morwenn commented Mar 9, 2020 •
edited
Loading

@madebr To be honest I don't know whether it would help, but it does look like something that would help. I will definitely give it a try if it gets in.

@conan-center-bot
Copy link
Contributor

Some configurations of 'llvm-openmp/9.0.1' failed in build 3 (a07a8da3bebbd55ff18d8e1e9c5c2e4871ad0829):

@conan-center-bot
Copy link
Contributor

All green in build 4 (3afc17e382a4b9609ab5ed72db08bfde158e861d)! 😊

@vvilpas
Copy link
Contributor Author

vvilpas commented Apr 1, 2020

@madebr @danimtb Please, could you review again? Thanks!

uilianries
uilianries requested changes Apr 1, 2020
View reviewed changes
@vvilpas @Croydon
Apply suggestions from code review
6dd91e1 
Co-Authored-By: Michael "Croydon" Keck <git@cr0ydon.com>
uilianries
uilianries previously approved these changes Apr 1, 2020
View reviewed changes
@conan-center-bot
Copy link
Contributor

All green in build 5 (6dd91e17e1acc3fceb2c6518335c7efa6a91edeb)! 😊

@uilianries uilianries requested a review from SSE4 April 1, 2020 18:25
SSE4
SSE4 previously approved these changes Apr 3, 2020
View reviewed changes
@vvilpas
Copy link
Contributor Author

vvilpas commented Apr 6, 2020

Hi @danimtb! Is there anything else missing in order to merge?

@jgsogo jgsogo mentioned this pull request Apr 24, 2020
Open
jgsogo
jgsogo previously approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been thinking about the better approach for the LLVM related stuff and we don't have a response yet given the functionality currently available in Conan (we need a better graph model, and we are working on it 😉). Here you can read the rationale and follow it in the future: #683 (comment)

I've suggested a change, the short_name is not an attribute recognized by Conan and can disappear in a following revision of this recipe, just in case any other script/package public or private is using it.

Thanks for the contribution!

@vvilpas vvilpas dismissed stale reviews from jgsogo, SSE4, and uilianries via 62c23d6 April 27, 2020 15:14
@conan-center-bot
Copy link
Contributor

All green in build 6 (62c23d61b89a5f56f7a2ce5d1f1218b4c452cf2c)! 😊

@vvilpas vvilpas requested a review from jgsogo April 27, 2020 16:25
@jgsogo jgsogo requested review from uilianries and SSE4 April 27, 2020 16:51
@jgsogo jgsogo merged commit 2085220 into conan-io:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danimtb danimtb danimtb approved these changes

@uilianries uilianries Awaiting requested review from uilianries

@SSE4 SSE4 Awaiting requested review from SSE4

+3 more reviewers

@Croydon Croydon Croydon left review comments

@madebr madebr madebr left review comments

@jgsogo jgsogo jgsogo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jgsogo jgsogo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@vvilpas @conan-center-bot @Morwenn @SSE4 @jgsogo @Croydon @madebr @uilianries @danimtb