poc of testing and installing build_requires as build_requires #8627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasote
reviewed
Mar 10, 2021
conans/client/installer.py
Outdated
| @@ -576,7 +577,10 @@ def _propagate_info(self, node, using_build_profile): | |||
|
|
|||
| for n in node_order: | |||
| if n not in transitive: | |||
| conan_file.output.info("Applying build-requirement: %s" % str(n.ref)) | |||
| try: | |||
| conan_file.output.info("Applying build-requirement: %s" % str(n.ref)) | |||
There was a problem hiding this comment.
The printing of virtual consumers is disabled, because it was very confusing to users, seeing something like (virtual): Applying build-requirement.... So conanfile.output.info or any other printing command will raise for RECIPE_VIRTUAL recipe.
conans/test/integration/build_requires/test_install_test_build_require.py
Show resolved
Hide resolved
conans/client/graph/graph_manager.py
Outdated
| @@ -290,11 +304,11 @@ def _recurse_build_requires(self, graph, builder, check_updates, | |||
| for node in graph.ordered_iterate(nodes_subset): | |||
| # Virtual conanfiles doesn't have output, but conanfile.py and conanfile.txt do | |||
| # FIXME: To be improved and build a explicit model for this | |||
| if node.recipe == RECIPE_VIRTUAL: | |||
| continue | |||
| #if node.recipe == RECIPE_VIRTUAL: | |||
There was a problem hiding this comment.
Virtual recipes couldn't have build_requires so far, only regular requires. This is opening the door for this possibility.
SSE4
reviewed
Mar 11, 2021
| @@ -306,8 +306,11 @@ def load_virtual(self, references, profile_host, scope_options=True, | |||
| conanfile.conf = profile_host.conf.get_conanfile_conf(None) | |||
| conanfile.settings = profile_host.processed_settings.copy_values() | |||
|
|
|||
| for reference in references: | |||
| conanfile.requires.add_ref(reference) | |||
| if is_build_require: | |||
There was a problem hiding this comment.
may they have the same interface? e.g.
if is_build_require:
for reference in references:
conanfile.build_requires.add_ref(reference)
else:
for reference in references:
conanfile.requires.add_ref(reference)
SSE4
reviewed
Mar 11, 2021
| cmd = ". ./activate.sh && mycmake.sh" if platform.system() != "Windows" else \ | ||
| "activate.bat && mycmake.bat" | ||
| client.run_command(cmd) | ||
| system = {"Darwin": "Macos"}.get(platform.system(), platform.system()) |
There was a problem hiding this comment.
why this pattern is repeating and needed?
lasote
approved these changes
May 24, 2021
czoido
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: New
conan install <ref> --build-requireandconan create <path> --build-require(when not usingtest_package) arguments to explicitly define that the installed or created package has to be abuild-require, receiving the build profile instead of the host one.Docs: omit
This follows #8787 that added support for the
test_package.To discuss: Should we use
--build-requirealways forconan create, even if it is defined intest_package/conanfile.pywithtest_type = "build_requires"?#tags: slow