Linea Goerli cUSDCv3 deploy #758

Julink-eth · 2023-06-13T15:55:40Z

Add changes to support deployment and scenarios for linea goerli network.

kevincheng96

Looks good overall! Left some minor comments here and there. A lot of the diff is formatting related which I think can be reverted.

kevincheng96 · 2023-06-13T16:57:06Z

deployments/goerli/usdc/roots.json

@@ -9,5 +9,6 @@
    "arbitrumInbox": "0x6BEbC4925716945D46F0Ec336D5C2564F419682C",
    "arbitrumL1GatewayRouter": "0x4c7708168395aEa569453Fc36862D2ffcDaC588c",
    "baseL1CrossDomainMessenger": "0x8e5693140eA606bcEB98761d9beB1BC87383706D",
-    "baseL1StandardBridge": "0xfA6D8Ee5BE770F84FC001D098C4bD604Fe01284a"
+    "baseL1StandardBridge": "0xfA6D8Ee5BE770F84FC001D098C4bD604Fe01284a",
+    "zkEvmV2": "0x70BaD09280FD342D02fe64119779BC1f0791BAC2"


I think lineaMessageService is a better name for this. zkEvmV2 seems too broad and generic.

kevincheng96 · 2023-06-13T16:58:11Z

contracts/bridges/linea/LineaBridgeReceiver.sol

+import './IMessageService.sol';
+import '../BaseBridgeReceiver.sol';
+
+contract LineaBridgeReceiver is BaseBridgeReceiver {


Talked about this offline. Since this contract is payable, we should extend the SweepableBridgeReceiver contract.

kevincheng96 · 2023-06-13T16:59:28Z

deployments/linea-goerli/usdc/configuration.json

+  "baseToken": "USDC",
+  "baseTokenAddress": "0xf56dc6695cF1f5c364eDEbC7Dc7077ac9B586068",
+  "baseTokenPriceFeed": "0xcb81fffa91cd5f3436318d25057c1d5df8e23f95",
+  "borrowMin": "100e6",


100e6 seems too high for an L2. I recommend something like 1e6.

kevincheng96 · 2023-06-13T17:00:10Z

deployments/linea-goerli/usdc/configuration.json

+    "baseSupplySpeed": "0.000011574074074074073e15",
+    "baseBorrowSpeed": "0.0011458333333333333e15",


Ideally, we set these as 0 on deploy and increase them with a cross-chain governance proposal.

kevincheng96 · 2023-06-13T17:00:36Z

deployments/linea-goerli/usdc/configuration.json

+      "borrowCF": 0.775,
+      "liquidateCF": 0.825,
+      "liquidationFactor": 0.95,
+      "supplyCap": "50_000e18"


Same here. We set them as 0 on deploy and increase them afterwards.

kevincheng96 · 2023-06-13T17:05:25Z

plugins/deployment_manager/DeploymentManager.ts

Could we remove the changes in this file? Seems like these are all just formatting changes.

kevincheng96 · 2023-06-13T17:05:43Z

deployments/localhost/usdc/roots.json

Can remove this change.

kevincheng96 · 2023-06-13T17:06:11Z

plugins/deployment_manager/Verify.ts

Same here. We can remove these since these are all just formatting changes.

kevincheng96 · 2023-06-13T17:07:02Z

plugins/import/etherscan.ts

+    // TODO remove this condition
+    if (network === 'linea-goerli') {
+      res = (
+        await axios.get(url, {
+          params: data,
+          auth: {
+            username: 'eslineastage',
+            password: 'QW$eKsy3J%~v'
+          }
+        })
+      )['data'];


Note: Remember to remove.

Good catch thank you, completely forgot about that TODO

Following up on this again, did you want to remove this before merging?

kevincheng96 · 2023-06-13T17:13:30Z

tasks/deployment_manager/task.ts

Are the diffs in this file all just formatting changes? If so, let's revert the changes.

contracts/bridges/linea/LineaBridgeReceiver.sol

+    constructor(address _messageService) {
+        messageService = IMessageService(_messageService);
+    }


contracts/bridges/linea/LineaBridgeReceiver.sol

+    constructor(address _messageService) {
+        messageService = IMessageService(_messageService);
+    }


scott-silver · 2023-06-13T17:29:07Z

hardhat.config.ts

-  for (let i = 0; i < n; i++)
-    yield (BigInt('0x' + pk) + BigInt(i)).toString(16);
+function* deriveAccounts(pk: string, n: number = 10) {
+  for (let i = 0; i < n; i++) yield (BigInt('0x' + pk) + BigInt(i)).toString(16);


Can we remove the formatting changes to this file? Seems unnecessary

kevincheng96 · 2023-06-13T18:50:21Z

One thing that is missing is the migration script to create a cross-chain proposal to initialize Comet (increase supply caps, set COMP speeds, etc.). Here's an example.

Julink-eth · 2023-06-14T08:13:15Z

I just added the changes to fix all the comments you guys had except the one for the migration file that I will in another commit.
If I may add just one comment, all the formatting issues seemed to have occured because of the file .prettierrc.json that specifies  

{
  "singleQuote": true,
  "printWidth": 100
}

And a lot of files don’t respect those rules, I know it’s not the PR to do this kind of clean up, I just wanted to bring that up :)

Julink-eth · 2023-06-14T08:42:10Z

One thing that is missing is the migration script to create a cross-chain proposal to initialize Comet (increase supply caps, set COMP speeds, etc.). Here's an example.

What values should I put in this file, can I just use the exact same values as what's been done for base-goerli ?

kevincheng96 · 2023-06-14T18:52:56Z

If I may add just one comment, all the formatting issues seemed to have occured because of the file .prettierrc.json that specifies

Yeah, that is our bad. Through this PR, we realized that we should either enforce the Prettier or just remove it. We removed it in #760.

What values should I put in this file, can I just use the exact same values as what's been done for base-goerli ?

Yes, values such as the amount of COMP to bridge could be the same. However, a lot of the values used in the proposal are actually pulled from the configuration.json file when calling getConfigurationStruct. So it will actually be a 2-step process:

Set supply caps and reward speeds to 0 in configuration.json. Deploy the contracts with this initial configuration so Comet is not live yet.
Update the supply caps and reward speeds in configuration.json. Run the migration script (which pulls in these updated configuration) to create the on-chain proposal.

We usually keep the migration script in a separate PR for this reason.

Julink-eth · 2023-06-14T18:59:15Z

Yes, values such as the amount of COMP to bridge could be the same. However, a lot of the values used in the proposal are actually pulled from the configuration.json file when calling getConfigurationStruct. So it will actually be a 2-step process:

Set supply caps and reward speeds to 0 in configuration.json. Deploy the contracts with this initial configuration so Comet is not live yet.

Update the supply caps and reward speeds in configuration.json. Run the migration script (which pulls in these updated configuration) to create the on-chain proposal.

We usually keep the migration script in a separate PR for this reason.

Thank you very clear, in that case if you can review my last changes taking care of all the comments except the migration that'd be great.
I'll make a new PR for the migration once this one is accepted.

kevincheng96 · 2023-06-15T22:00:24Z

Thank you very clear, in that case if you can review my last changes taking care of all the comments except the migration that'd be great.

Thanks for making the changes. Overall looks good! Left a few comments about some formatting changes, but not urgent and blocking.

Looks like the CI jobs aren't running because your forked repo doesn't have the env vars set up. What we could do is have you merge the PR into a feature branch so we can run the tests using the env vars in our Comet repo. I created the linea/usdc-deploy branch and will change the target of this PR to point there instead.

I'll make a new PR for the migration once this one is accepted.

I don't think we should let the merging of this PR block the migration work. The code to make a proposal can still be executed without being merged into main. In fact, we run the migration and make sure the proposal passes first before merging.

kevincheng96 · 2023-06-15T21:20:31Z

deployments/linea-goerli/usdc/roots.json

Looks like roots have been cleared and may require a re-deploy. We'll need this to update the front-end.

Oh my bad I meant to remove the ones in the localhost folder.
We still needed to redo a deployment anyway for the LineaBridgerReceiver change

kevincheng96 · 2023-06-15T21:21:58Z

plugins/import/import.ts

I don't think there are any diffs in this file outside of formatting changes right? Let's revert

kevincheng96 · 2023-06-15T21:23:04Z

scenario/BulkerScenario.ts

Not urgent, but would prefer to remove the formatting diffs.

kevincheng96 · 2023-06-15T21:23:19Z

scenario/CrossChainGovernanceScenario.ts

Not urgent, but would prefer to remove the formatting diffs.

kevincheng96 · 2023-06-15T21:23:31Z

scenario/utils/index.ts

Not urgent, but would prefer to remove the formatting diffs.

…enBridge to the configuration

Julink-eth · 2023-06-16T12:18:28Z

I pushed the latest changes to account for the latest comments.
I have redeployed the contracts, so the roots.json has been updated, also I added one more contract to the relations.ts:
lineaL1TokenBridge that will be used in the migration script.
Let me know if there is anything that needs to be changed.

I'm working on a different branch for the migration script: #763

kevincheng96

Thanks for making the changes. Left a final comment to follow up on removing the password. Everything else looks good!

kevincheng96 · 2023-06-16T16:44:35Z

scenario/BulkerScenario.ts

@@ -7,7 +7,7 @@ import { exp } from '../test/helpers';
 scenario(
  'Comet#bulker > (non-WETH base) all non-reward actions in one txn',
  {
-    filter: async (ctx) => await isBulkerSupported(ctx) && !matchesDeployment(ctx, [{deployment: 'weth'}, {network: 'mumbai'}]),
+    filter: async (ctx) => await isBulkerSupported(ctx) && !matchesDeployment(ctx, [{deployment: 'weth'}, {network: 'mumbai'}, { network: 'linea-goerli' }]),


Curious why we need to exclude Linea from this test?

Otherwise the scenario was failing, I can't remember should I remove it ?

Yeah I think it's better to let the scenario fail so we can see if it's an actual problem or not.

kevincheng96 · 2023-06-16T16:46:22Z

plugins/import/etherscan.ts

+    // TODO remove this condition
+    if (network === 'linea-goerli') {
+      res = (
+        await axios.get(url, {
+          params: data,
+          auth: {
+            username: 'eslineastage',
+            password: 'QW$eKsy3J%~v'
+          }
+        })
+      )['data'];


Following up on this again, did you want to remove this before merging?

kevincheng96 · 2023-06-16T17:09:44Z

Another question: Are the supported assets minted by Linea or bridged from Goerli? If the former, I recommend sending a good amount to the Fauceteer so users can claim small amounts of it to play around with the protocol.

Julink-eth · 2023-06-16T17:11:55Z

#758 (comment)
It should be removed, this is outdated.

Julink-eth · 2023-06-16T17:14:00Z

Another question: Are the supported assets minted by Linea or bridged from Goerli? If the former, I recommend sending a good amount to the Fauceteer so users can claim small amounts of it to play around with the protocol.

COMP, USDC, ETH should be bridged from goerli to Linea.
In our quests we already give the users faucets to get those assets on Linea :)

* feat: messageService wrapper (WIP) * feat: deployment script (WIP) * feat: deployment script - adapt for Linea * feat: config - adapt for Linea * chore: delete unnecessary file * feat: update hardhat config (WIP) * fix: pragma conflict * fix: LineaBridgeReceiver issue * feat: add Linea config * fix: add lineascan_key * fix: add lineascan_key to github actions * feat: wip linea deployment * Base Goerli cWETHv3 deploy (#751) This PR introduces the cWETHv3 deployment on Base Goerli as well as the proposal to initialize the market there. When initializing the cWETHv3 market, we bridge over some WETH reserves. However, Optimism/Base does not support bridging WETH directly, so we bridge over ETH instead and wrap it before sending it to cWETHv3. I had to add some logic to our mock relayer code to support bridging of ETH. * Deploy script for cWETHv3 on Base Goerli * Create proposal to initialize cWETHv3 and bridge ETH as reserves * Run base-goerli-weth in scenarios CI * Fix pricefeeds path after rebase * Address PR comments * Modified deployment roots from GitHub Actions * Update proposal * Modified migration from GitHub Actions --------- Co-authored-by: GitHub Actions Bot <> * Adding the Semgrep worflow by Decurity (#742) This Semgrep workflow runs 2 rule sets over all the pull requests. The rule sets include both generic Solidity security detections and the comet-specific ones. We've reviewed the comet repository issues, pull requests and commits and created a few rules according to the fixes that were proposed by OZ/ChainSecurity/Certora and have been accepted by Compound. Most of the issues have been closed without fixes, and some of others are unfeasible to detect with Semgrep. You can see it in action here: Decurity#2 Right now if you run these rules over the whole comet codebase, the stats is as follows: Ran 9 rules on 36 files: 32 findings. 23 of these are missing sanity checks on constructor arguments (each argument = 1 finding). Of course many of them might not require the sanity checks so this rule can spam the alerts if run over the whole codebase but can be useful if run over the new contracts (there's only one constructor, so there won't be overwhelmingly many findings) Also there's a couple of "A constant name is not in UPPER_CASE like other constant variables." and "Event parameters with type 'address' should be indexed" findings. * Create .github/workflows/semgrep.yml * add compound specific semgrep rules * add env vars --------- Co-authored-by: Raz0r <me@raz0r.name> * feat: added Linea L1 message service contract in the configuration * feat: working solution, missing verification on etherscan * chore: rename arg no-deploy to noDeploy * feat: added linea cross chain governance scenario * feat: added relayMessage for linea * fix: cross chain governance tests for linea-goerli * feat: mage LineaBridgeReceiver fallback payable and removed comments * chore: new deployment with different account * feat: added missing changes for linea deployment/scenarios * fix: take into account compound team's comment except the migration file * feat: fixed formatting, reset configuration.json and added lineaL1TokenBridge to the configuration * feat: reduced baseMinForRewards to 1000e6 * feat: added migration script for linea-goerli to set reward config and ens text record * feat: added linea comp address in the migration script, remove COMP asset from the configuration.json * feat: fixed typo unit256 to uint256 + changed config values to be the the same as base goerli * Remove prettier (#760) The Comet repo currently has rules set up for both Prettier and ESLint, even though we only enforce the rules for ESLint. The move from Prettier to ESLint was decided in #321. Keeping the Prettier configs in the repo while not enforcing them is arguably worse than just not having the configs in the first place, since contributors may end up running the Prettier (e.g. via VSCode auto-format) for some files and introduce very large diffs. Removing Prettier should help reduce the formatting diffs introduced by contributors. * Make OptimismBridgeReceiver sweepable (#759) This change should extend the `OptimismBridgeReceiver` with some functionality to sweep ERC20 and native tokens. * Linea Goerli cUSDCv3 deploy (#758) * feat: messageService wrapper (WIP) * feat: deployment script (WIP) * feat: deployment script - adapt for Linea * feat: config - adapt for Linea * chore: delete unnecessary file * feat: update hardhat config (WIP) * fix: pragma conflict * fix: LineaBridgeReceiver issue * feat: add Linea config * fix: add lineascan_key * fix: add lineascan_key to github actions * feat: wip linea deployment * feat: added linea cross chain governance scenario * feat: added Linea L1 message service contract in the configuration * feat: added relayMessage for linea * feat: working solution, missing verification on etherscan * chore: rename arg no-deploy to noDeploy * fix: cross chain governance tests for linea-goerli * feat: mage LineaBridgeReceiver fallback payable and removed comments * chore: new deployment with different account * feat: added missing changes for linea deployment/scenarios * fix: take into account compound team's comment except the migration file * feat: fixed formatting, reset configuration.json and added lineaL1TokenBridge to the configuration * feat: reduced baseMinForRewards to 1000e6 --------- Co-authored-by: Arthur <arthur@coeos.xyz> * fix: LineaBridgeReceiver artifact path * feat: updated linea COMP address * fix: migration issues * feat: added WBTC as collateral * feat: added verification for liquidateCollateralFactor * fix: WBTC contract + added usdc specific bridge to transfer usdc from L1 to linea * fix: usdc decimals * fix: fixed WBTC contract + use usdcbridge in the scenario * fix: fixed last isssues --------- Co-authored-by: Arthur <arthur@coeos.xyz> Co-authored-by: Kevin Cheng <kevincheng96@hotmail.com> Co-authored-by: Omar Ganiev <beched@decurity.io> Co-authored-by: Raz0r <me@raz0r.name>

This PR supports a cUSDCv3 deployment on Linea Goerli (deploy script + migration script). Most of the work was done by the Linea dev team. * Linea Goerli cUSDCv3 deploy (#758) * feat: messageService wrapper (WIP) * feat: deployment script (WIP) * feat: deployment script - adapt for Linea * feat: config - adapt for Linea * chore: delete unnecessary file * feat: update hardhat config (WIP) * fix: pragma conflict * fix: LineaBridgeReceiver issue * feat: add Linea config * fix: add lineascan_key * fix: add lineascan_key to github actions * feat: wip linea deployment * feat: added linea cross chain governance scenario * feat: added Linea L1 message service contract in the configuration * feat: added relayMessage for linea * feat: working solution, missing verification on etherscan * chore: rename arg no-deploy to noDeploy * fix: cross chain governance tests for linea-goerli * feat: mage LineaBridgeReceiver fallback payable and removed comments * chore: new deployment with different account * feat: added missing changes for linea deployment/scenarios * fix: take into account compound team's comment except the migration file * feat: fixed formatting, reset configuration.json and added lineaL1TokenBridge to the configuration * feat: reduced baseMinForRewards to 1000e6 --------- Co-authored-by: Arthur <arthur@coeos.xyz> * Feat: linea migration script (#763) * feat: messageService wrapper (WIP) * feat: deployment script (WIP) * feat: deployment script - adapt for Linea * feat: config - adapt for Linea * chore: delete unnecessary file * feat: update hardhat config (WIP) * fix: pragma conflict * fix: LineaBridgeReceiver issue * feat: add Linea config * fix: add lineascan_key * fix: add lineascan_key to github actions * feat: wip linea deployment * Base Goerli cWETHv3 deploy (#751) This PR introduces the cWETHv3 deployment on Base Goerli as well as the proposal to initialize the market there. When initializing the cWETHv3 market, we bridge over some WETH reserves. However, Optimism/Base does not support bridging WETH directly, so we bridge over ETH instead and wrap it before sending it to cWETHv3. I had to add some logic to our mock relayer code to support bridging of ETH. * Deploy script for cWETHv3 on Base Goerli * Create proposal to initialize cWETHv3 and bridge ETH as reserves * Run base-goerli-weth in scenarios CI * Fix pricefeeds path after rebase * Address PR comments * Modified deployment roots from GitHub Actions * Update proposal * Modified migration from GitHub Actions --------- Co-authored-by: GitHub Actions Bot <> * Adding the Semgrep worflow by Decurity (#742) This Semgrep workflow runs 2 rule sets over all the pull requests. The rule sets include both generic Solidity security detections and the comet-specific ones. We've reviewed the comet repository issues, pull requests and commits and created a few rules according to the fixes that were proposed by OZ/ChainSecurity/Certora and have been accepted by Compound. Most of the issues have been closed without fixes, and some of others are unfeasible to detect with Semgrep. You can see it in action here: Decurity#2 Right now if you run these rules over the whole comet codebase, the stats is as follows: Ran 9 rules on 36 files: 32 findings. 23 of these are missing sanity checks on constructor arguments (each argument = 1 finding). Of course many of them might not require the sanity checks so this rule can spam the alerts if run over the whole codebase but can be useful if run over the new contracts (there's only one constructor, so there won't be overwhelmingly many findings) Also there's a couple of "A constant name is not in UPPER_CASE like other constant variables." and "Event parameters with type 'address' should be indexed" findings. * Create .github/workflows/semgrep.yml * add compound specific semgrep rules * add env vars --------- Co-authored-by: Raz0r <me@raz0r.name> * feat: added Linea L1 message service contract in the configuration * feat: working solution, missing verification on etherscan * chore: rename arg no-deploy to noDeploy * feat: added linea cross chain governance scenario * feat: added relayMessage for linea * fix: cross chain governance tests for linea-goerli * feat: mage LineaBridgeReceiver fallback payable and removed comments * chore: new deployment with different account * feat: added missing changes for linea deployment/scenarios * fix: take into account compound team's comment except the migration file * feat: fixed formatting, reset configuration.json and added lineaL1TokenBridge to the configuration * feat: reduced baseMinForRewards to 1000e6 * feat: added migration script for linea-goerli to set reward config and ens text record * feat: added linea comp address in the migration script, remove COMP asset from the configuration.json * feat: fixed typo unit256 to uint256 + changed config values to be the the same as base goerli * Remove prettier (#760) The Comet repo currently has rules set up for both Prettier and ESLint, even though we only enforce the rules for ESLint. The move from Prettier to ESLint was decided in #321. Keeping the Prettier configs in the repo while not enforcing them is arguably worse than just not having the configs in the first place, since contributors may end up running the Prettier (e.g. via VSCode auto-format) for some files and introduce very large diffs. Removing Prettier should help reduce the formatting diffs introduced by contributors. * Make OptimismBridgeReceiver sweepable (#759) This change should extend the `OptimismBridgeReceiver` with some functionality to sweep ERC20 and native tokens. * Linea Goerli cUSDCv3 deploy (#758) * feat: messageService wrapper (WIP) * feat: deployment script (WIP) * feat: deployment script - adapt for Linea * feat: config - adapt for Linea * chore: delete unnecessary file * feat: update hardhat config (WIP) * fix: pragma conflict * fix: LineaBridgeReceiver issue * feat: add Linea config * fix: add lineascan_key * fix: add lineascan_key to github actions * feat: wip linea deployment * feat: added linea cross chain governance scenario * feat: added Linea L1 message service contract in the configuration * feat: added relayMessage for linea * feat: working solution, missing verification on etherscan * chore: rename arg no-deploy to noDeploy * fix: cross chain governance tests for linea-goerli * feat: mage LineaBridgeReceiver fallback payable and removed comments * chore: new deployment with different account * feat: added missing changes for linea deployment/scenarios * fix: take into account compound team's comment except the migration file * feat: fixed formatting, reset configuration.json and added lineaL1TokenBridge to the configuration * feat: reduced baseMinForRewards to 1000e6 --------- Co-authored-by: Arthur <arthur@coeos.xyz> * fix: LineaBridgeReceiver artifact path * feat: updated linea COMP address * fix: migration issues * feat: added WBTC as collateral * feat: added verification for liquidateCollateralFactor * fix: WBTC contract + added usdc specific bridge to transfer usdc from L1 to linea * fix: usdc decimals * fix: fixed WBTC contract + use usdcbridge in the scenario * fix: fixed last isssues --------- Co-authored-by: Arthur <arthur@coeos.xyz> Co-authored-by: Kevin Cheng <kevincheng96@hotmail.com> Co-authored-by: Omar Ganiev <beched@decurity.io> Co-authored-by: Raz0r <me@raz0r.name> * Small clean up * More fixes * Modified migration from GitHub Actions * feat: increase supply caps for ETH and WBTC for the linea quest (#772) * feat: increase supply caps for ETH and WBTC for the linea quest * feat: removed unecessary spider call + nit * Fix supply cap migration script * Modified migration from GitHub Actions * Remove empty roots.json * Fix min borrow amount * Add COMP whale --------- Co-authored-by: Julink <julien.fontanel12@gmail.com> Co-authored-by: Arthur <arthur@coeos.xyz> Co-authored-by: Omar Ganiev <beched@decurity.io> Co-authored-by: Raz0r <me@raz0r.name> Co-authored-by: GitHub Actions Bot <>

arthur-remy and others added 24 commits May 29, 2023 14:49

feat: messageService wrapper (WIP)

f152f75

feat: deployment script (WIP)

3ed3853

feat: deployment script - adapt for Linea

4fa8b88

feat: config - adapt for Linea

e1aadc5

chore: delete unnecessary file

c099ccd

feat: update hardhat config (WIP)

5aee84a

fix: pragma conflict

b87331a

fix: LineaBridgeReceiver issue

55b806d

feat: add Linea config

7252fd2

fix: add lineascan_key

8922231

fix: add lineascan_key to github actions

4566a2b

chore: fix merge main

aba069f

feat: wip linea deployment

2476f11

feat: added linea cross chain governance scenario

a74a17a

chore: merged main

fc239eb

feat: added Linea L1 message service contract in the configuration

62154a3

feat: added relayMessage for linea

7861e2a

feat: working solution, missing verification on etherscan

66ec365

chore: rename arg no-deploy to noDeploy

68c19e7

Merge branch 'feat/linea-tests' into Linea-support

caa94a8

fix: cross chain governance tests for linea-goerli

f9cf897

feat: mage LineaBridgeReceiver fallback payable and removed comments

ed616c8

chore: new deployment with different account

74915f4

feat: added missing changes for linea deployment/scenarios

0089b7b

kevincheng96 reviewed Jun 13, 2023

View reviewed changes

github-advanced-security bot found potential problems Jun 13, 2023

View reviewed changes

scott-silver reviewed Jun 13, 2023

View reviewed changes

fix: take into account compound team's comment except the migration file

d037b90

kevincheng96 reviewed Jun 15, 2023

View reviewed changes

kevincheng96 changed the base branch from main to linea/usdc-deploy June 15, 2023 22:01

Julink-eth added 2 commits June 16, 2023 12:23

feat: fixed formatting, reset configuration.json and added lineaL1Tok…

ad5b60c

…enBridge to the configuration

feat: reduced baseMinForRewards to 1000e6

35e3a40

Julink-eth mentioned this pull request Jun 16, 2023

Feat: linea migration script #763

Merged

kevincheng96 approved these changes Jun 16, 2023

View reviewed changes

kevincheng96 merged commit b21d267 into compound-finance:linea/usdc-deploy Jun 16, 2023

Julink-eth deleted the Linea-support branch June 21, 2023 22:17

		"baseSupplySpeed": "0.000011574074074074073e15",
		"baseBorrowSpeed": "0.0011458333333333333e15",

Linea Goerli cUSDCv3 deploy #758

Linea Goerli cUSDCv3 deploy #758

Uh oh!

Conversation

Julink-eth commented Jun 13, 2023

Uh oh!

kevincheng96 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Check notice

Check warning

Choose a reason for hiding this comment

Uh oh!

kevincheng96 commented Jun 13, 2023

Uh oh!

Julink-eth commented Jun 14, 2023

Uh oh!

Julink-eth commented Jun 14, 2023

Uh oh!

kevincheng96 commented Jun 14, 2023

Uh oh!

Julink-eth commented Jun 14, 2023

Uh oh!

kevincheng96 commented Jun 15, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Julink-eth commented Jun 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kevincheng96 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kevincheng96 commented Jun 16, 2023

Uh oh!

Julink-eth commented Jun 16, 2023

Uh oh!

Julink-eth commented Jun 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Julink-eth commented Jun 16, 2023 •

edited

Loading

Julink-eth commented Jun 16, 2023 •

edited

Loading