-
Notifications
You must be signed in to change notification settings - Fork 528
forwardport PR#110 #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
forwardport PR#110 #232
Conversation
I don't understand why this change is not merged yet. It is very useful when we push new tags into a git repo. |
@Seldaek What's your opinion on this one? Given the fact that webhooks from Github/Bitbucket only contain Git repository URLs and not Composer package names, this change would be very useful to trigger updates for single packages. |
Why doesn't this use the merging of packages as the package filter does, see https://github.com/Tyrael/satis/blob/partial_update/src/Composer/Satis/Command/BuildCommand.php#L195 - is the cache file really needed? |
@Tyrael I realize the history, but would be nice to update this now then if possible? |
sure, and I will update the PR, I was just answering your question why was this not done that way in the first place :) |
5919688
to
0adab41
Compare
@naderman any chance you had the time to review this? |
if (($singleRepositoryUrl = $input->getOption('repository-url')) !== null) { | ||
$singleRepositoryConfig = null; | ||
foreach ($config['repositories'] as $r) { | ||
if ($r['url'] == $singleRepositoryUrl) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should use strict comparison
while going through the comments from @stof I've just realized that @naderman suggestion in #232 (comment) was probably that we should instead extend selectPackages() and loadDumpedPackages() with a $repositoriesFilter similarly how it was done for $packagesFilter. |
How does it look? I could really use this, I have patched satis for now |
It needs to be rebased unfortunately. |
@Tyrael Can you please try to move this forward if you have time? Or I can try it if you are busy. |
originally I just forwardported the quick and dirty solution but then I realized/was suggested a better approach but then got swamped with work at my dayjob and couldn't finish it. |
Just for clarification... I assume combining Wouldn't it be better/easier to reuse |
I looked at the latest code and it moved miles ahead... After a bit of searching I found that this could be easily solved with just changing
Although I am not sure if it should go there. Any thoughts @alcohol, @Tyrael ? |
@realshadow you mean you want to introduce changes to Composer for a feature in Satis? That is unlikely to happen unless you have a really good reason. Also I kind of lost track of what this PR was trying to accomplish since it's a port of a port (and I don't use Satis myself). |
@alcohol Not really. Just saying :) It was trying to accomplish building of a single/multiple repositories with repository url instead of package name. The original proposal was for Although on second thought, the original code, with slight alterations should be enough to cover this use case... |
The code was mostly broken into smaller manageable pieces. It should still exist to some extend. |
I have created a new PR #266 which uses |
I guess it can be closed ;) |
this PR is basically the same as #110 but it should apply to the current master without any conflicts.