Improve error message on zip bomb #12399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seldaek
added a commit
to Seldaek/composer
that referenced
this pull request
May 12, 2025
|
Thanks, change is definitely good, and thanks for figuring out which package.. This let me identify a problematic file like https://github.com/cebe/markdown/blob/master/tests/markdown-data/dos2.md (makes sense that this compresses well 😆 ) and now I got a confirmed fix for this issue too in #12409 |
Seldaek
added a commit
that referenced
this pull request
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improvement for diagnosing issues like #12369
After installing composer from source and patching up the ZipDownloader as instructed, I managed to track down the issue to https://github.com/cebe/markdown which is a dependency of Yii2, more specifically caused by this file which would be best if it could be ignored since its a test file.
Since the library in question has last been released in 2018, I'm not holding my hopes up that it will be fixed, so we will be looking at alternatives.
In any case, this proposed error message would have made it 1000x easier to figure out what went wrong and why.
Edit: reported issues on PHPStan and PHP 8.3 seems unrelated?